Bug 264354 - security/strongswan: Add CTR plugin option
Summary: security/strongswan: Add CTR plugin option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-30 19:46 UTC by Björn König
Modified: 2022-06-01 22:09 UTC (History)
3 users (show)

See Also:
strongswan: maintainer-feedback+

Attachments
Add CTR plugin option (2.55 KB, patch)
2022-05-30 19:46 UTC, Björn König 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn König 2022-05-30 19:46:49 UTC 
Created attachment 234333 [details]
Add CTR plugin option

Add CTR plugin option

Add CTR OPTION. When enabled it will add --enable-ctr parameter to configure and build CTR cipher mode wrapper plugin.
Comment 1 Tobias Brunner 2022-05-31 08:50:07 UTC 
Note that it would probably also be possible to add support for AES-CTR to the openssl plugin, which the port enables by default.
Comment 2 Francois ten Krooden 2022-05-31 11:32:39 UTC 
(In reply to Tobias Brunner from comment #1)
I'll check then I can incorporate it with this change
Comment 3 Tobias Brunner 2022-05-31 14:05:40 UTC 
@Francois I've pushed a patch to the openssl-ctr branch that adds CTR mode support for AES and Camellia (as used with IKE/ESP) to the openssl plugin.
Comment 4 Francois ten Krooden 2022-06-01 07:58:53 UTC 
Comment on attachment 234333 [details]
Add CTR plugin option

Happy with the patch
Comment 5 Francois ten Krooden 2022-06-01 07:59:32 UTC 
(In reply to Tobias Brunner from comment #3)
Will test it out Tobias
Comment 6 Francois ten Krooden 2022-06-01 08:01:05 UTC 
The patch can be applied.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-06-01 22:08:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3a2477de75eeaac86240462bd3d76abef0c2c2c

commit b3a2477de75eeaac86240462bd3d76abef0c2c2c
Author:     Björn König <freebsd@koenigbj.8bx.de>
AuthorDate: 2022-06-01 21:52:04 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2022-06-01 22:03:17 +0000

    security/strongswan: add CTR plugin option

    PR:             264354
    Approved by:    Francois ten Krooden (maintainer)

 security/strongswan/Makefile  | 5 ++++-
 security/strongswan/pkg-plist | 4 ++++
 2 files changed, 8 insertions(+), 1 deletion(-)
Comment 8 Dries Michiels freebsd_committer freebsd_triage 2022-06-01 22:09:47 UTC 
Thanks, committed with minor modification!