Bug 264506 - x11-toolkits/copperspice: fix build on armv6/armv7
Summary: x11-toolkits/copperspice: fix build on armv6/armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Adriaan de Groot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-06 21:10 UTC by Robert Clausecker
Modified: 2022-06-12 21:52 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (adridg)
fuz: merge-quarterly?


Attachments
x11-toolkits/copperspice: fix build on armv6/armv7 (2.80 KB, patch)
2022-06-06 21:10 UTC, Robert Clausecker
fuz: maintainer-approval? (adridg)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-06-06 21:10:14 UTC
Created attachment 234500 [details]
x11-toolkits/copperspice: fix build on armv6/armv7

Please find attached a patch to fix the build of this port on armv6/armv7.  Builds fine in Poudriere.

An unrelated issue I noticed is that the port will try to build additional plugins when the relevant dependencies are available on the system (for example, a postgres plugin).  This causes the pkg-plist check to fail when building without Poudriere.  You should try to control what components are being built in a more fine grained manner.

Please MFH if possible.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-06-12 20:41:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5f104f3192f7fbbe809570b9b3d85ba778e5207f

commit 5f104f3192f7fbbe809570b9b3d85ba778e5207f
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-06-05 00:15:51 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-06-12 20:40:11 +0000

    x11-toolkits/copperspice: fix build on armv7

    PR:             264506

 ..._JavaScriptCore_jit_ExecutableAllocator.h (new) | 27 ++++++++++++++++++++++
 .../files/patch-src_core_global_qglobal.h (new)    | 19 +++++++++++++++
 2 files changed, 46 insertions(+)
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2022-06-12 20:58:32 UTC
THanks for the patch. I've applied it unchanged. Since it's against WebKit, I expected to find something similar in other Qt5-derived ports, but did not; it might have been fixed in Qt5 sometime after CS forked.

I'm not going to MFH: Q2 ends in less than 3 weeks, this port is not in any way essential (or even useful for anything beyond the Diamond editor).
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-06-12 21:52:18 UTC
(In reply to Adriaan de Groot from comment #2)

Hi there,

Upstream Webkit has completely refactored this part of the code, so no need to send them any of this.  And indeed, Qt5 is not affected by this issue.  I had originally tried to find a patch I could just add to PATCH_FILES, but didn't
find any particular commit that would solve the issue.

Long term it might probably be best to unbundle Webkit and consolidate all the patches from the dozen or so Webkits shipped with FreeBSD, but that'll probably not happen any time soon.