Bug 264512 - x11-toolkits/swt: update to 4.21
Summary: x11-toolkits/swt: update to 4.21
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-07 00:16 UTC by huanghwh
Modified: 2022-06-07 12:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (makc)

Attachments
swt.diff (9.70 KB, patch)
2022-06-07 00:16 UTC, huanghwh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description huanghwh 2022-06-07 00:16:43 UTC 
Created attachment 234511 [details]
swt.diff

- sync patches with eclipse 4.21
- remove patch-org_eclipse_swt_graphics_Device.java as it make so big icon in eclipse
- add patch-org_eclipse_swt_widgets_Shell.java as it fixed wrong position on Hidpi with scale 200%
Comment 1 Max Brazhnikov freebsd_committer freebsd_triage 2022-06-07 12:18:04 UTC 
I do have crashes without patch-org_eclipse_swt_graphics_Device.java similar to bug 254041. Apparently swt still doesn't find *.css files at runtime. Do you know how to fix this?
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-06-07 12:38:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d551e5b93e20225875d3b682bb6dc93412d03680

commit d551e5b93e20225875d3b682bb6dc93412d03680
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2022-06-07 12:37:25 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2022-06-07 12:38:03 +0000

    x11-toolkits/swt: update to 4.21

    - Sync patches with eclipse 4.21
    - Remove patch-org_eclipse_swt_graphics_Device.java (which breaks
      icons in Eclipse) and install missing *.css files
    - Add patch-org_eclipse_swt_widgets_Shell.java to fix layout on HiDPI
      scaled to 200%

    PR:             264512 (based on)
    Submmitted by:  huanghwh@gmail.com

 x11-toolkits/swt/Makefile                          |  7 +++---
 x11-toolkits/swt/distinfo                          |  6 +++---
 x11-toolkits/swt/files/build.xml                   |  3 +--
 x11-toolkits/swt/files/patch-OS.java (gone)        | 22 -------------------
 ...patch-org_eclipse_swt_browser_WebKit.java (new) | 11 ++++++++++
 ...tch-org_eclipse_swt_graphics_Device.java (gone) | 11 ----------
 ...tch-org_eclipse_swt_internal_Library.java (new) | 16 ++++++++++++++
 ...atch-org_eclipse_swt_internal_gtk_OS.java (new) | 13 +++++++++++
 .../patch-org_eclipse_swt_widgets_Shell.java (new) | 20 +++++++++++++++++
 x11-toolkits/swt/files/patch-os.c                  |  4 ++--
 .../swt/files/swt_functional_gtk_3_20.css (new)    | 13 +++++++++++
 .../swt/files/swt_theming_fixes_gtk_3_20.css (new) | 25 ++++++++++++++++++++++
 .../files/swt_theming_fixes_gtk_3_24_5.css (new)   |  3 +++
 13 files changed, 111 insertions(+), 43 deletions(-)
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2022-06-07 12:40:02 UTC 
Committed with some modifications. Thanks!