Bug 264642 - math/libmesh: Use upstream release archive
Summary: math/libmesh: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-12 20:34 UTC by Daniel Engberg
Modified: 2022-06-12 21:22 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+

Attachments
Patch for libmesh (3.06 KB, patch)
2022-06-12 20:34 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-06-12 20:34:46 UTC 
Created attachment 234649 [details]
Patch for libmesh

* Use upstream release archive as suggested by Porters Handbook (USE_GITHUB section ) and upstream [1], this also reduces download size by more than 50%
* Update requirements to c++17 (upstream defines -std=gnu++17 during build) in port Makefile

1: https://github.com/libMesh/libmesh/releases/tag/v1.7.0

Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-12 20:37:48 UTC 
Hi Daniel,

Thanks for the patch.

Approved.


Yuri
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-12 20:45:51 UTC 
And by the way, bump is missing.
plist change requires the bump.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-06-12 20:47:18 UTC 
I'll add that, thanks! :-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-06-12 21:22:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7cc5ab5148cae72addea11f1e5e155bd56a3b42

commit a7cc5ab5148cae72addea11f1e5e155bd56a3b42
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-06-12 20:48:05 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-06-12 20:48:09 +0000

    math/libmesh: Use upstream release archive and some minor fixes

    * Use upstream release archive as suggested by Porters Handbook
      (USE_GITHUB section ) and upstream, this also reduces
      download size by more than 50%
    * Update requirements to c++17 (upstream defines -std=gnu++17
      during build)

    PR:             264642
    Reviewed by:    yuri

 math/libmesh/Makefile  | 12 +++---------
 math/libmesh/distinfo  | 12 +++---------
 math/libmesh/pkg-plist |  5 +++--
 3 files changed, 9 insertions(+), 20 deletions(-)