Bug 264706 - multimedia/audacious-plugins: Remove libmms support
Summary: multimedia/audacious-plugins: Remove libmms support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks: 264708
  Show dependency tree / graph
 
Reported: 2022-06-16 07:13 UTC by Daniel Engberg
Modified: 2022-07-04 19:41 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+

Attachments
Patch for audacious-plugins (1.70 KB, patch)
2022-06-16 07:13 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-06-16 07:13:28 UTC 
Created attachment 234722 [details]
Patch for audacious-plugins

Time to retire support, Microsoft deprecated MMS in 2003

Reference:
https://en.wikipedia.org/wiki/Microsoft_Media_Server
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2022-06-16 10:51:44 UTC 
(In reply to Daniel Engberg from comment #0)



Hi!

I have no objection but since the expiration of the library is in September I'd ask to wait a little before removing support.

I will remove it from the default options though.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-06-16 11:22:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d4466596fa90d1e0e36916fc1621383d467679d2

commit d4466596fa90d1e0e36916fc1621383d467679d2
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2022-06-16 11:20:28 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-06-16 11:20:28 +0000

    multimedia/audacious-plugins: Disable MMS option by default

    The MMS protocol has been deprecated upstream since 2003.

    PR:             264706, 264708

 multimedia/audacious-plugins/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-04 19:31:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f5f8e7efb1110b09d43e2780bbcb0c7bb34b65a4

commit f5f8e7efb1110b09d43e2780bbcb0c7bb34b65a4
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-07-04 19:27:55 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-07-04 19:30:26 +0000

    multimedia/audacious-plugins: Remove libmms option

    Remove the MMS option (disabled by default) which depends on
    deprecated net/libmms.

    PR:             264706

 multimedia/audacious-plugins/Makefile  | 8 +++-----
 multimedia/audacious-plugins/pkg-plist | 1 -
 2 files changed, 3 insertions(+), 6 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2022-07-04 19:41:25 UTC 
Option removed.

Thanks.