Bug 264798 - graphics/webp: Conditionalize image converters
Summary: graphics/webp: Conditionalize image converters
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-20 22:02 UTC by Adam Weinberger
Modified: 2022-06-21 21:26 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
IMGCONV option (2.08 KB, patch)
2022-06-20 22:02 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2022-06-20 22:02:26 UTC
Created attachment 234828 [details]
IMGCONV option

Hi Po-Chuan!

gohugo recently added a hard dep on WebP. The problem is that WebP has hard deps on a lot of other graphics libraries that aren't a part of the actual WebP decoder library.

WebP uses those other libraries for command-line image conversion tools. This patch adds an IMGCONV option (enabled by default so the default package won't change). With IMGCONV disabled, WebP becomes just a library with a few file info tools.

The default package doesn't change, but I bumped PORTREVISION anyway just in case. I'm not confident about it... I'll leave that to your discretion.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-06-21 21:01:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=81d2af56be29daa64a3d29c79b76136a25f33394

commit 81d2af56be29daa64a3d29c79b76136a25f33394
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-06-21 20:58:56 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-06-21 20:58:56 +0000

    graphics/webp: Add IMGCONV option

    PR:             264798
    Submitted by:   adamw

 graphics/webp/Makefile  | 13 ++++++++-----
 graphics/webp/pkg-plist | 16 ++++++++--------
 2 files changed, 16 insertions(+), 13 deletions(-)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-06-21 21:02:17 UTC
Committed. Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-06-21 21:26:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e07cd0e5fd4211550db6ca7a7ec1e64d3f45731e

commit e07cd0e5fd4211550db6ca7a7ec1e64d3f45731e
Author:     Adam Weinberger <adamw@FreeBSD.org>
AuthorDate: 2022-06-21 21:23:44 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2022-06-21 21:25:24 +0000

    graphics/webp: Move USES=jpeg under IMGCONV

    The jpeg library is only needed for the image conversion library. I
    missed it in the original patch.

    PR:             264798

 graphics/webp/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)