Bug 264830 - www/yt-dlp: fails to fetch 2022.06.22.1
Summary: www/yt-dlp: fails to fetch 2022.06.22.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2022-06-22 17:02 UTC by Jan Beich
Modified: 2022-06-22 21:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-06-22 17:02:42 UTC 
Regressed by ports 7a64d4ddf15f

$ make checksum TRYBROKEN= MASTER_SITE_BACKUP= DISTDIR=$(mktemp -dt distfiles)
===>  License UNLICENSE accepted by the user
===>   yt-dlp-2022.06.22.1_1 depends on file: /usr/local/sbin/pkg - found
=> yt-dlp-yt-dlp-2022.06.22.1_GH0.tar.gz doesn't seem to exist in /tmp/distfiles.O7WEAmdYVq/.
=> Attempting to fetch https://codeload.github.com/yt-dlp/yt-dlp/tar.gz/2022.06.22.1?dummy=/yt-dlp-yt-dlp-2022.06.22.1_GH0.tar.gz
fetch: https://codeload.github.com/yt-dlp/yt-dlp/tar.gz/2022.06.22.1?dummy=/yt-dlp-yt-dlp-2022.06.22.1_GH0.tar.gz: size mismatch: expected 2065673, actual 2065654
=> Couldn't fetch it - please try to retrieve this
=> port manually into /tmp/distfiles.O7WEAmdYVq/ and try again.
*** Error code 1
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-22 17:09:51 UTC 
The fixed the bug that I myself reported right after the release yesterday and re-released it.

Thanks for your report!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-06-22 17:10:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac5d331d12c9afcdd413f5860d84a65e0c63bc60

commit ac5d331d12c9afcdd413f5860d84a65e0c63bc60
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-06-22 17:07:14 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-06-22 17:09:54 +0000

    www/yt-dlp: Fix fetch

    The project was re-released after a bugfix.

    PR:             264830
    Reported by:    jbeich@

 www/yt-dlp/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-06-22 17:35:44 UTC 
Perheps a better solution is to use a SUBDIR ${PORTNAME}/${DISTVERSION} and use the official tarballs?
https://github.com/yt-dlp/yt-dlp/releases/download/2022.06.22.1/yt-dlp.tar.gz

Best regards,
Daniel
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-22 19:12:22 UTC 
(In reply to Daniel Engberg from comment #3)

Daniel,

Currently USE_GITHUB=yes is just one line.
With official tarball download it's going to be 3+ lines.
So it becomes slightly longer without any obvious benefit.

Yuri
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-06-22 20:50:59 UTC 
(In reply to Yuri Victorovich from comment #4)
The obvious benefit would be static distribution file(s) so we would never have breakage like this. I agree that it would be nice if upstream used a better naming schema though.
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2022-06-22 21:22:13 UTC 
(In reply to Daniel Engberg from comment #5)

No, re-rolling the release tarball would have caused breakage just the same way.