Bug 264878 - security/base-audit: Mark DEPRECATED and set EXPIRATION_DATE
Summary: security/base-audit: Mark DEPRECATED and set EXPIRATION_DATE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-24 20:58 UTC by Yasuhiro Kimura
Modified: 2022-08-19 10:02 UTC (History)
3 users (show)

See Also:
yasu: maintainer-feedback+


Attachments
Patch file (794 bytes, patch)
2022-06-24 20:58 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (11.64 KB, patch)
2022-06-26 02:29 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2022-06-24 20:58:08 UTC
Created attachment 234921 [details]
Patch file

Mark DEPRECATED and set EXPIRATION_DATE.

405.pkg-base-audit is merged into ports-mgmt/pkg.
Comment 1 Miroslav Lachman 2022-06-25 21:26:45 UTC
(In reply to Yasuhiro Kimura from comment #0)
Yes please, remove this port. I already post about it almost a year ago
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212306

And I don't think it is necessary to DEPRECATED it first if there is "built-in replacement" in the package of pkg which is already installed.
Maybe it would be good to add entry into UPDATING.
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2022-06-26 02:29:48 UTC
Created attachment 234940 [details]
Updated patch file

* Remove port.
* Add entry to MOVED and UPDATING.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-26 16:24:44 UTC
^Triage: Reporter is committer, assign accordingly.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-18 16:13:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ad528e1c8370284c561f4b4800337735c02b0440

commit ad528e1c8370284c561f4b4800337735c02b0440
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2022-07-18 16:09:03 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2022-07-18 16:09:03 +0000

    security/base-audit: Remove port

    * Remove port as 405.pkg-base-audit, core file of the port, is merged
      into ports-mgmt/pkg with pkg 1.18.1.
    * Add entry to MOVED

    PR:             264878
    Approved by:    maintainer

 MOVED                                              |   1 +
 security/Makefile                                  |   1 -
 security/base-audit/Makefile (gone)                |  31 ---
 .../base-audit/files/405.pkg-base-audit.in (gone)  | 223 ---------------------
 security/base-audit/pkg-descr (gone)               |   4 -
 security/base-audit/pkg-message (gone)             |  21 --
 6 files changed, 1 insertion(+), 280 deletions(-)
Comment 5 Rob LA LAU 2022-08-18 22:07:49 UTC
Please add this merge/removal to /usr/ports/UPDATING.

See here for details:
https://forums.freebsd.org/threads/how-to-uninstall-a-package-without-pkg.86211/

Thanks,
  Rob
Comment 6 Miroslav Lachman 2022-08-19 07:06:24 UTC
(In reply to Rob LA LAU from comment #5)
It seems to me like a bug in portmaster. I think direct use of pkg to upgrade installed packages handles this automatically well, uninstalls base-audit, upgrade pkg and then the rest of the packages. Am I right?
Uninstalling pkg as the first step seems wrong to me.
Comment 7 Rob LA LAU 2022-08-19 07:43:53 UTC
Not everybody installs from packages, many sysadmins install from ports.
And maybe you're right: maybe portmaster should check for conflicts and merges before uninstalling anything. I'll report this to the portmaster team as well.
But /usr/ports/UPDATING is for caveats that sysadmins can run into when updating ports, and this is a pretty tricky caveat that can be encountered at this moment.

I'm not saying anyone is at fault here; I'm just saying that it might be nice to give a little heads up.
I'll leave it up to you.

Cheers,
  Rob
Comment 8 Miroslav Lachman 2022-08-19 10:02:21 UTC
(In reply to Rob LA LAU from comment #7)
I agree that it will be helpful to add this info in to UPDATING even if it is just for portmaster users. Some committer can add it.