Bug 264946 - security/nettle: Enable aarch64 assembly optimization
Summary: security/nettle: Enable aarch64 assembly optimization
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-28 22:03 UTC by Daniel Engberg
Modified: 2022-07-11 13:58 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for nettle (15.12 KB, patch)
2022-06-28 22:03 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-06-28 22:03:38 UTC 
Created attachment 234988 [details]
Patch for nettle

This patch backports upstream commit d4c7597e4236f746434c9a1a24f6191f7ff870cd to fix compilation with aarch64 assembly code and mikael@ provided glue for runtime detection of hardware features/instructions

Tested on RockPro64 with GnuTLS (13.1-RELEASE)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-07-09 20:59:44 UTC 
Friendly ping
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-11 13:54:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a8ebe6902a15a11102372d0575c18cc9a01f19b1

commit a8ebe6902a15a11102372d0575c18cc9a01f19b1
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-07-11 13:51:34 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-07-11 13:51:34 +0000

    security/nettle: Fix build of assembly code on aarch64

    PR:             264946
    Reported by:    diizzy
    Tested by:      diizzy (RockPro64 with GnuTLS on 13.1-RELEASE)
    Obtained from:  https://git.lysator.liu.se/nettle/nettle/-/commit/d4c7597e4236f746434c9a1a24f6191f7ff870cd

 security/nettle/Makefile                           |   4 -
 .../files/patch-arm64-chacha-4core.asm (new)       | 146 +++++++++++++++++++++
 security/nettle/files/patch-fat-arm64.c (new)      |  27 ++++
 .../patch-powerpc64-p7-chacha-4core.asm (new)      | 130 ++++++++++++++++++
 .../files/patch-s390x-vf-chacha-4core.asm (new)    | 130 ++++++++++++++++++
 5 files changed, 433 insertions(+), 4 deletions(-)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-07-11 13:58:15 UTC 
Committed. Thanks!