Bug 264967 - java/eclipse: Makefile cleanup
Summary: java/eclipse: Makefile cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-30 21:37 UTC by Jonathan Chen
Modified: 2022-07-06 21:02 UTC (History)
1 user (show)

See Also:

Attachments
git-diff (892 bytes, patch)
2022-06-30 21:37 UTC, Jonathan Chen 		jonc: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2022-06-30 21:37:18 UTC 
Created attachment 235008 [details]
git-diff

- disable PORTSCOUT
- remove now superflous WRKSRC_SUBDIR
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-05 06:01:39 UTC 
Why do we want to disable PORTSCOUT?
Comment 2 Jonathan Chen 2022-07-05 09:56:53 UTC 
I keep getting false positives. I had a look at the documentation, and there doesn't seem to be a way to pick up git tags.

Portscout is currently informing me that nightly-builds are the latest versions. They aren't.
Comment 3 Jonathan Chen 2022-07-05 09:57:57 UTC 
I can't work out how to translate R4_24 builds to 4.24 of the port.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-06 20:51:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3d3be85dd2c2e72fe1431f8e060307f4eeb41e30

commit 3d3be85dd2c2e72fe1431f8e060307f4eeb41e30
Author:     Jonathan Chen <jonc@chen.org.nz>
AuthorDate: 2022-07-05 05:58:24 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-06 20:48:03 +0000

    java/eclipse: Makefile cleanup

     * disable PORTSCOUT
     * remove now superflous WRKSRC_SUBDIR

    PR:     264967
    Reported by:    jonc@chen.org.nz (maintainer)

 java/eclipse/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-06 21:02:02 UTC 
Committed,

Thanks!