Created attachment 235100 [details] diff for walld A Wallpaper daemon. By default it changes wallpapers every 30 minutes.
Minor review items: - The following aren't necessary (their values inherit from / default to PORTNAME and PORTVERSION): GH_PROJECT= walld GH_TAGNAME= 1.4.1 - Suggest primary category 'deskutils' Could you also confirm the port passes QA (portlint, poudriere)
Created attachment 235136 [details] moves the package to deskutils and removes unessacary variables
I can confirm that this passes portlint. I can also confirm that it builds on poudriere 13.1-RELEASE on amd64.
Looks close to finished! Good work. Last nit; ideally we use the ports framework for as many things as we can as its more flexible when bumping default versions, etc. In this case, I see there is a "USES" for ImageMagick dependencies. So preferred to use; USES= magick:7,lib (in this case version 7 is the default https://cgit.freebsd.org/ports/tree/Mk/bsd.default-versions.mk under the hood you can see here what it does: https://cgit.freebsd.org/ports/tree/Mk/Uses/magick.mk) So we can concatenate to: USES= magick,lib over LIB_DEPENDS= libMagickCore-7.so:graphics/ImageMagick7 Could you include all changes in one patch file?
Created attachment 235163 [details] full patch for walld
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7c4dd5a4b829a33391871ddf8107892217e611f9 commit 7c4dd5a4b829a33391871ddf8107892217e611f9 Author: Dotz0cat <Dotz0cat@gmail.com> AuthorDate: 2022-07-10 07:37:03 +0000 Commit: Dries Michiels <driesm@FreeBSD.org> CommitDate: 2022-07-10 08:13:38 +0000 deskutils/walld: add new port Walld automatically changes the wallpaper. It sets the wallpaper through feh. It changes the wallpaper by default every 30 minutes. PR: 265067 deskutils/Makefile | 1 + deskutils/walld/Makefile (new) | 20 ++++++++++++++++++++ deskutils/walld/distinfo (new) | 3 +++ deskutils/walld/pkg-descr (new) | 4 ++++ deskutils/walld/pkg-plist (new) | 3 +++ 5 files changed, 31 insertions(+)
Committed, thanks!