Created attachment 235108 [details] patch New port for malloy: A C++ library providing HTTP(S) and WebSocket(Secure) client and server components. Passes portlint Passes poudriere-testport
Created attachment 235113 [details] patch
Created attachment 235158 [details] patch Updated based on feedback by Zirias: - Add USES=ssl instead of listing OpenSSL as a dependency - Use LIB_DEPENDS where reasonable - Add IGNORE for unsupported scenarios
Further remarks, for discussion: * IMHO, leave out RUN_DEPENDS. Although boost is needed for compiling stuff with this lib, it would also force installation of boost for any possible future consumer of the lib. * After learning that missing C++20 STL headers are actually a bug, I'd opt to remove the current IGNORE magic and just add a suitable BROKEN_FreeBSD_12 instead, e.g.: BROKEN_FreeBSD_12= some C++20 STL headers are missing on 12.3,\  see https://bugs.freebsd.org/255374
Oh and I think architectures shouldn't be restricted unless it's proven not to work on a certain arch...
Please use _DEPENDS directly, don't hide it using additional variables I'd agree that you can probably just require 13+ for now unless there's a user demand and drop ONLY_FOR_ARCHS unless you know its broken on other archs ..and since you're the project admin, please upload release tarballs Best regards, Daniel
(In reply to Daniel Engberg from comment #5) Thank you for your feedback - I will update the port accordingly. By now, this port has been tested successfully on i386, amd64 and arm64/aarch64 so I agree that the ONLY_FOR_ARCHS is misused/obsolete at this point. > I'd agree that you can probably just require 13+ How would I go about doing that properly? The main issue is that this port requires at least 13.1. It won't build on a 13.0 system.
Created attachment 235393 [details] patch Updated Makefile as per the feedback received. > ..and since you're the project admin, please upload release tarballs I'll look into that for the next release. I was under the impression that tarballs generated by GitHub are sufficient.
Comment on attachment 235393 [details] patch Now that 13.0 is EOL this is no longer an issue as all that's needed is a BROKEN_ for 12. I'll update the port accordingly next week.
Comment on attachment 235393 [details] patch Looks good to me.
(In reply to Joel Bodenmann from comment #9) Looks good, yes. Looking at "MALLOY_FEATURE_TLS MALLOY_FEATURE_CLIENT MALLOY_FEATURE_SERVER", I wonder: would it make sense to turn them into (on-by-default) port options? I mean, there's probably a reason they are optional features upstream? Just a suggestion of course ;)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b8913b6c0cbf578b8930924729aa31b21b66281d commit b8913b6c0cbf578b8930924729aa31b21b66281d Author: Joel Bodenmann <jbo@insane.engineer> AuthorDate: 2022-07-20 18:32:00 +0000 Commit: Felix Palmen <zirias@FreeBSD.org> CommitDate: 2022-09-05 17:07:40 +0000 devel/malloy: Add new port Embeddable HTTP(S) and WS(S) components for C++20. PR: 265077 Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D36460 devel/Makefile | 1 + devel/malloy/Makefile (new) | 63 +++++++++++++++++++++++++ devel/malloy/distinfo (new) | 3 ++ devel/malloy/pkg-descr (new) | 7 +++ devel/malloy/pkg-plist (new) | 110 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 184 insertions(+)
Committed, thanks!