Bug 265110 - x11-wm/hikari: crashes when opening Gtk4 apps
Summary: x11-wm/hikari: crashes when opening Gtk4 apps
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Ashish SHUKLA
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-07-09 10:29 UTC by Ahmad Raniri
Modified: 2022-07-11 03:34 UTC (History)
2 users (show)

See Also:
ashish: maintainer-feedback+
ashish: merge-quarterly+

Attachments
Gdb run and backstrace full. (1.93 KB, text/plain)
2022-07-09 10:29 UTC, Ahmad Raniri 		no flags Details
x11-wm/hikari diff (1.38 KB, patch)
2022-07-10 14:08 UTC, Ashish SHUKLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Raniri 2022-07-09 10:29:50 UTC 
Created attachment 235146 [details]
Gdb run and backstrace full.

Hikari wayland compositor will crash when opening gtk4 apps (e.g celluloid), there is a patch available at hikari's matrix forum and it's fixed the issue. Will be great if the patch get applied to hikari port.

The patch link : https://gist.github.com/ahmadraniri1994/8a5e5b47fd9bfbf5bc11e6fbc490c79a
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2022-07-10 12:26:49 UTC 
My FreeBSD desktop is not working at the moment, so it'll be hard for me to test this attached patch, but I can perform the build, and commit that, assuming it worked fine for you.

Although before I commit this patch, could you please share the source of the patch so I can also properly attribute/credit the author ?

Thanks!
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2022-07-10 14:08:34 UTC 
Created attachment 235172 [details]
x11-wm/hikari diff

Hi,

Thanks for translating that darcs diff to unified diff.

Could you please try this attached diff to the port, and see if it works for you ?

Once you confirm, I'll commit it.

Thanks!
Comment 3 Ahmad Raniri 2022-07-11 01:30:06 UTC 
Thanks Ashish SHUKLA, it works now.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-11 03:32:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c48fee7e6adef8939a7fbbb031e308cbbc809cd4

commit c48fee7e6adef8939a7fbbb031e308cbbc809cd4
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2022-07-10 13:53:29 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-07-11 03:26:46 +0000

    x11-wm/hikari: Patch to prevent crashing with GTK4 apps

    PR:             265110
    Reported by:    Ahmad Raniri <ahmadraniri1994 at gmail dot com>
    Tested by:      Ahmad Raniri <ahmadraniri1994 at gmail dot com>
    Obtained from:  alex at xanderio dot de
    MFH:            2022Q3 (bug fix)

 x11-wm/hikari/Makefile                       |  1 +
 x11-wm/hikari/files/patch-src_server.c (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-11 03:33:14 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d9c5b9cac42a22716f292fca5717c9842fdf464

commit 5d9c5b9cac42a22716f292fca5717c9842fdf464
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2022-07-10 13:53:29 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-07-11 03:31:58 +0000

    x11-wm/hikari: Patch to prevent crashing with GTK4 apps

    PR:             265110
    Reported by:    Ahmad Raniri <ahmadraniri1994 at gmail dot com>
    Tested by:      Ahmad Raniri <ahmadraniri1994 at gmail dot com>
    Obtained from:  alex at xanderio dot de
    MFH:            2022Q3 (bug fix)

    (cherry picked from commit c48fee7e6adef8939a7fbbb031e308cbbc809cd4)

 x11-wm/hikari/Makefile                       |  1 +
 x11-wm/hikari/files/patch-src_server.c (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+)
Comment 6 Ashish SHUKLA freebsd_committer freebsd_triage 2022-07-11 03:34:18 UTC 
Thanks for sharing the patch, and help with testing.

Marking as resolved.