Bug 265174 - net/remmina: Make python dependency optional and move it to USES
Summary: net/remmina: Make python dependency optional and move it to USES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 16:44 UTC by Vladimir Druzenko
Modified: 2022-07-12 20:41 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (fernape)


Attachments
Make python dependency optional and move it to USES (2.07 KB, patch)
2022-07-12 16:44 UTC, Vladimir Druzenko
vvd: maintainer-approval? (fernape)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2022-07-12 16:44:01 UTC
Created attachment 235221 [details]
Make python dependency optional and move it to USES

Use mandatory dependency on python with force version isn't good idea, IMHO: LIB_DEPENDS=libpython3.9.so:lang/python39
Replaced with optional PYTHON_USES=python

Tested on 13.1 amd64 with PYTHON ON and OFF: check-plist, install, run.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-12 20:40:29 UTC
Committed,

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-12 20:41:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3236c81b2bdb52e1f7bc722070e8eaa719cac3bc

commit 3236c81b2bdb52e1f7bc722070e8eaa719cac3bc
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2022-07-12 17:38:04 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-12 20:37:26 +0000

    net/remmina: Make python dependency optional

    Remmina supports plugins written in python. Create option for that instead of
    having python as a hard dependency.

    PR:     265174
    Reported by:    vvd@unislabs.com

 net/remmina/Makefile  | 10 +++++++---
 net/remmina/pkg-plist |  2 +-
 2 files changed, 8 insertions(+), 4 deletions(-)