Bug 265229 - math/pspp: does not build
Summary: math/pspp: does not build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-15 08:24 UTC by Miroslav Lachman
Modified: 2022-07-18 17:19 UTC (History)
3 users (show)

See Also:
fernape: merge-quarterly+


Attachments
poudriere build log (49.64 KB, text/plain)
2022-07-15 08:24 UTC, Miroslav Lachman
no flags Details
config.log from failed build (69.45 KB, application/gzip)
2022-07-15 10:00 UTC, Miroslav Lachman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Lachman 2022-07-15 08:24:09 UTC
Created attachment 235265 [details]
poudriere build log

checking for iconv... yes
checking for working iconv... yes
checking for iconv declaration... 
         extern size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);
configure: error: The following required packages are not installed.
You must install them before PSPP can be built:
	cairo 1.5 or later and pango 1.22 or later
===>  Script "configure" failed unexpectedly.
Please report the problem to ports@FreeBSD.org [maintainer] and attach the
"/wrkdirs/usr/ports/math/pspp/work/pspp-1.6.1/config.log" including the output
of the failure of your make command. Also, it might be a good idea to provide
an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

pspp cannot be built after recent version upgrade from 1.4 to 1.6. There is some problem with dependencies and their options. What works for pspp 1.4 does not work for 1.6.1 but I don't know what it was.
I am building quarterly packages so I moved from 2022Q2 to 2022Q3 sources and changed default Python version from 3.7 to 3.9. This is only change I made. pspp was built on previous quarterly but cannot be built on current quarterly 2022Q3.

Full poudriere log attached.
Comment 1 Miroslav Lachman 2022-07-15 09:30:13 UTC
Note I am building it without GUI (for headless server without X11) and NLS.

---Begin OPTIONS List---
===> The following configuration options are available for pspp-1.6.1:
     DOCS=off: Build and/or install documentation
     EXAMPLES=on: Build and/or install examples
     GUI=off: GUI (Graphical User Interface) support
     NLS=off: Native Language Support
     PGSQL=off: PostgreSQL database support
===> Use 'make config' to modify these settings
---End OPTIONS List---


Previous version has only these 4 dependencies:
# pkg info -d pspp
pspp-1.4.1_3:
        libxml2-2.9.13_1
        indexinfo-0.3.1
        gsl-2.7.1
        readline-8.1.2

No cairo / pango / gtk etc.
Comment 2 Miroslav Lachman 2022-07-15 09:59:41 UTC
It seems cairo + pango are now required, not optional:

http://git.savannah.gnu.org/cgit/pspp.git/commit/INSTALL?id=def6f19d1b58929ed31ae6a7a90f89054ab3ace7

2021-01-08: Make the Cairo and Pango libraries required rather than optional.
This eliminates a lot of difficult-to-maintain conditional compilation.
It also fixes the broken build of the manual when Cairo was not available.
Comment 3 Miroslav Lachman 2022-07-15 10:00:27 UTC
Created attachment 235267 [details]
config.log from failed build
Comment 4 Miroslav Lachman 2022-07-15 10:39:48 UTC
When I expanded LIB_DEPENDS it builds but I don't know if it is right way to do it:

LIB_DEPENDS=    libgslcblas.so:math/gsl \
                libcairo.so:graphics/cairo \
                libpango-1.0.so:x11-toolkits/pango
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-18 15:25:23 UTC
Committed,

Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-07-18 15:25:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5281a948fa9ec3a76bb8454a15b7ee8f22e0e7de

commit 5281a948fa9ec3a76bb8454a15b7ee8f22e0e7de
Author:     Miroslav Lachman <000.fbsd@quip.cz>
AuthorDate: 2022-07-18 06:36:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-18 15:21:34 +0000

    math/pspp: Fix build

    cairo and pango are required dependencies.

    PR:     265229
    Reported by:    000.fbsd@quip.cz

 math/pspp/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 7 Miroslav Lachman 2022-07-18 15:36:38 UTC
Can you commit this fix to quarterly 2022Q3 too?
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-18 17:19:05 UTC
Done.

Thanks for the heads up!
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-07-18 17:19:51 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f6637307271a78422e3cbbbca89f589cb1941337

commit f6637307271a78422e3cbbbca89f589cb1941337
Author:     Miroslav Lachman <000.fbsd@quip.cz>
AuthorDate: 2022-07-18 06:36:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-18 17:16:05 +0000

    math/pspp: Fix build

    cairo and pango are required dependencies.

    PR:     265229
    Reported by:    000.fbsd@quip.cz

    (cherry picked from commit 5281a948fa9ec3a76bb8454a15b7ee8f22e0e7de)

 math/pspp/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)