Created attachment 235321 [details] cad/librnd: update to 3.2.0 - apply a workaround from upstream SVN r34334 and r34335 to address a broken unit test Changelog: http://www.repo.hu/projects/librnd/releases/changelog-3.2.0.txt Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Q/A: WARN: /data/fernape_data/FreeBSD-repos/ports/cad/librnd/files/patch-tests_librnd_librnd_test.c: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. No need to update the diff, just use "make makepatch" to generate patches in files/. Thanks!
(In reply to Fernando Apesteguía from comment #1) Hi, this patch was taken as is from upstream. Therefore, it is not in makepatch format. I am under the impression that this is the preferred way of doing it.
(In reply to Robert Clausecker from comment #2) If the patch is going to be in files/ it is best if it conforms to the expected format (double underscores when expected, etc). If we want to apply a patch remotely (as in PATCHFILES) then I suppose it doesn't matter.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=89b6b25d78b0eda117b37476248a68ee0873fd51 commit 89b6b25d78b0eda117b37476248a68ee0873fd51 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-07-18 06:20:24 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-07-18 15:17:40 +0000 cad/librnd: update to 3.2.0 ChangeLog: http://www.repo.hu/projects/librnd/releases/changelog-3.2.0.txt PR: 265283 Reported by: fuz@fuz.su (maintainer) .../files/patch-tests_librnd_librnd__test.c (new) | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+)
(In reply to Fernando Apesteguía from comment #4) You only committed the test suite patch, not the changes to the Makefile to update to 3.2.0. Please commit the rest, too.
(In reply to Robert Clausecker from comment #6) Where is that update?
Created attachment 235339 [details] cad/librnd: update to 3.2.0 (for real this time) (In reply to Fernando Apesteguía from comment #7) Okay, this one is on me. I somehow forgot to squash my two local patches into one before submission.
Hi Robert, Are you able to provide the update for the Makefile? Thanks!
(In reply to Fernando Apesteguía from comment #9) I already have, please check attachment #235339 [details] from comment #8.
Done. Thanks!