Bug 265301 - security/py-acme security/py-certbot*: Update to 1.29.0
Summary: security/py-acme security/py-certbot*: Update to 1.29.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL: https://github.com/certbot/certbot/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-18 19:36 UTC by Yasuhiro Kimura
Modified: 2022-07-21 15:53 UTC (History)
1 user (show)

See Also:
sunpoet: maintainer-feedback+


Attachments
Patch file (12.26 KB, patch)
2022-07-18 19:36 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (28.17 KB, patch)
2022-07-19 02:02 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2022-07-18 19:36:37 UTC
Created attachment 235340 [details]
Patch file

Update to 1.29.0.

ChangeLog:      https://github.com/certbot/certbot/releases/tag/v1.29.0

* Build succeeds with poudriere and 13.1-RELEASE amd64 jail.
* Result of `make -C /usr/ports/security/py-acme test` is "291 passed, 76 warnings".
* Result of `make -C /usr/ports/security/py-certbot test` is "991 passed, 28 skipped, 445 warnings".
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-07-18 20:14:39 UTC
The patch seems incomplete [1]. Then I realized that the RUN_DEPENDS should be fixed.

Could you please refresh all RUN_DEPENDS to match their setup.py?
Take py-acme for example, RUN_DEPENDS [2] does not match its setup.py [3].

Thanks.

[1] https://github.com/certbot/certbot/compare/v1.27.0...v1.29.0#diff-17417fdd32efd3cc9828e7489699a449ec17dde8cbe9a5973bc207d44e17392b
[2] https://github.com/freebsd/freebsd-ports/blob/main/security/py-acme/Makefile#L16-L22
[3] https://github.com/certbot/certbot/blob/v1.29.0/acme/setup.py#L8-L17
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2022-07-19 02:02:19 UTC
Created attachment 235343 [details]
Updated patch file

Update dependencies.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-07-20 02:37:00 UTC
(In reply to Yasuhiro Kimura from comment #2)

Please commit it with one minor fix (changing all ">" to ">="). Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-21 15:52:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=530a30bd0d4c34f6ce625f0255f4df4a66c8c181

commit 530a30bd0d4c34f6ce625f0255f4df4a66c8c181
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2022-07-18 19:27:20 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2022-07-21 15:52:02 +0000

    security/py-{acme,certbot*}: Update to 1.29.0

    ChangeLog:      https://github.com/certbot/certbot/releases/tag/v1.29.0

    PR:             265301
    Approved by:    sunpoet (python@)

 security/py-acme/Makefile                     |  8 ++++----
 security/py-acme/distinfo                     |  6 +++---
 security/py-acme/version.mk                   |  2 +-
 security/py-certbot-apache/Makefile           |  4 +---
 security/py-certbot-apache/distinfo           |  6 +++---
 security/py-certbot-dns-cloudflare/Makefile   |  3 +--
 security/py-certbot-dns-cloudflare/distinfo   |  6 +++---
 security/py-certbot-dns-cloudxns/Makefile     |  3 +--
 security/py-certbot-dns-cloudxns/distinfo     |  6 +++---
 security/py-certbot-dns-digitalocean/Makefile |  3 +--
 security/py-certbot-dns-digitalocean/distinfo |  6 +++---
 security/py-certbot-dns-dnsimple/Makefile     |  3 +--
 security/py-certbot-dns-dnsimple/distinfo     |  6 +++---
 security/py-certbot-dns-dnsmadeeasy/Makefile  |  3 +--
 security/py-certbot-dns-dnsmadeeasy/distinfo  |  6 +++---
 security/py-certbot-dns-gehirn/Makefile       |  3 +--
 security/py-certbot-dns-gehirn/distinfo       |  6 +++---
 security/py-certbot-dns-google/Makefile       |  3 +--
 security/py-certbot-dns-google/distinfo       |  6 +++---
 security/py-certbot-dns-linode/Makefile       |  3 +--
 security/py-certbot-dns-linode/distinfo       |  6 +++---
 security/py-certbot-dns-luadns/Makefile       |  3 +--
 security/py-certbot-dns-luadns/distinfo       |  6 +++---
 security/py-certbot-dns-nsone/Makefile        |  3 +--
 security/py-certbot-dns-nsone/distinfo        |  6 +++---
 security/py-certbot-dns-ovh/Makefile          |  3 +--
 security/py-certbot-dns-ovh/distinfo          |  6 +++---
 security/py-certbot-dns-rfc2136/Makefile      |  3 +--
 security/py-certbot-dns-rfc2136/distinfo      |  6 +++---
 security/py-certbot-dns-route53/Makefile      |  3 +--
 security/py-certbot-dns-route53/distinfo      |  6 +++---
 security/py-certbot-dns-sakuracloud/Makefile  |  3 +--
 security/py-certbot-dns-sakuracloud/distinfo  |  6 +++---
 security/py-certbot-nginx/Makefile            |  5 ++---
 security/py-certbot-nginx/distinfo            |  6 +++---
 security/py-certbot/Makefile                  | 11 +++++------
 security/py-certbot/distinfo                  |  6 +++---
 37 files changed, 81 insertions(+), 99 deletions(-)