Created attachment 235390 [details] audio/dexed: fix build on armv7 arm64 Contrary to what was said in f5762a9, this was not caused by a compiler error but rather by the armv7/arm64 ABI using an unsigned character type. These platforms have unsigned character types. Fix various pieces of code that assume otherwise. While we are at it, kill -Werror as per policy. Tested with Poudriere on armv7 arm64 amd64 FreeBSD 13.1.
(In reply to Robert Clausecker from comment #0) Hi Robert, Thanks for the patch! Since this is a general problem it would be better to submit a pull request to Dexed on GitHub. Then PATCH_* lines should be added to backport it. Are you able to create such pull request? It would be better if you do it because you are the author of the patch. Thanks, Yuri
Hi, I can do that after you have committed the patch. I am not a fan of having ports stay broken for weeks while upstream is working out a fix as this can take forever and prevents the build fix from making progress.
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9f17ff970a755a8b6ba2388f9caf959ac8c46427 commit 9f17ff970a755a8b6ba2388f9caf959ac8c46427 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-07-20 17:10:00 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-07-20 17:10:00 +0000 audio/dexed: Fix build on armv7, arm64 PR: 265342 audio/dexed/Makefile | 4 +--- audio/dexed/files/patch-CMakeLists.txt (new) | 12 ++++++++++ .../dexed/files/patch-Source_PluginData.cpp (new) | 26 ++++++++++++++++++++++ .../files/patch-Source_PluginProcessor.h (new) | 13 +++++++++++ 4 files changed, 52 insertions(+), 3 deletions(-)
Please don't forget to MFH. I'm sorry for not requesting this in the first place.
(In reply to Robert Clausecker from comment #5) Will do, thanks.
A commit in branch 2022Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a65ad175973f24a0308f31d3578137f88238d327 commit a65ad175973f24a0308f31d3578137f88238d327 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-07-20 17:10:00 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-07-20 18:42:47 +0000 audio/dexed: Fix build on armv7, arm64 PR: 265342 (cherry picked from commit 9f17ff970a755a8b6ba2388f9caf959ac8c46427) audio/dexed/Makefile | 4 +--- audio/dexed/files/patch-CMakeLists.txt (new) | 12 ++++++++++ .../dexed/files/patch-Source_PluginData.cpp (new) | 26 ++++++++++++++++++++++ .../files/patch-Source_PluginProcessor.h (new) | 13 +++++++++++ 4 files changed, 52 insertions(+), 3 deletions(-)