Created attachment 235486 [details] patch This is a port of the QSchematic library. A Qt/C++ library providing widgets for drawing diagrams within Qt applications. Passes portlint. Tested with poudriere-testport on: - 12.3 amd64 - 13.0 amd64 - 13.0 i386 - 13.1 amd64 - 13.1 i386
Created attachment 235488 [details] patch Updated based on feedback received via IRC: Use PORTVERSION rather than DISTVERSION + GH_TAGNAME.
(In reply to Joel Bodenmann from comment #1) --- Example 7. Using DISTVERSION When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION. --- in https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions
(In reply to Nuno Teixeira from comment #2) It says so, although with an example of a DISTVERSION that would be translated to a PORTVERSION using only dots as separators. You're required to use PORTVERSION if the translated DISTVERSION would turn out "wrong". Now here, we have the super simple case that both will be exactly the same anyways. So far, I was under the impression that just using PORTVERSION in such cases would be fine.
So what's going to happen now? Can this be committed as-is or are changes expected/required?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=685fabbfb53b3f7cea47193e83a4fd9b8fdeec0f commit 685fabbfb53b3f7cea47193e83a4fd9b8fdeec0f Author: Joel Bodenmann <jbo@insane.engineer> AuthorDate: 2022-07-27 15:26:37 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-07-27 15:31:04 +0000 devel/qschematic: New port: Qt/C++ library providing widgets for drawing diagrams - submitter becomes maintainer QSchematic is a C++ library providing Qt widgets to easily draw diagrams and schematics in a Qt application. It uses Qt's graphics view framework. The library interface allows for easy customization of existing items and adding new custom items such as wires, nodes, connectors and similar. Drawn diagrams/schematics can be easily serialized to and from XML. A built-in netlist generator is provided to build a netlist form a drawn diagram/schematic. WWW: https://github.com/simulton/qschematic PR: 265449 devel/Makefile | 1 + devel/qschematic/Makefile (new) | 23 +++++++++++++++++++++ devel/qschematic/distinfo (new) | 3 +++ devel/qschematic/pkg-descr (new) | 10 +++++++++ devel/qschematic/pkg-plist (new) | 44 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+)
Committed, thanks!
(In reply to Nuno Teixeira from comment #6) Thank you too!