Created attachment 235489 [details]
patch

Comment 2 Nuno Teixeira 2022-07-26 15:04:48 UTC

Hi,

Could you share more info about new port?

- WWW url
- Description
- git diff against ports tree

Cheers

Hi Nuno,


I added the git diff as "patch" file attachment into this request.

The WWW url of this project is: https://github.com/r-darwish/topgrade

This tool helps to upgrade not only the os but also used package repositories like npm, cargo, ...
It supports a lot of OS's and Package repositories (see wiki: https://github.com/r-darwish/topgrade/wiki/Step-list)

Best,
C.

Comment 4 Nuno Teixeira 2022-07-27 10:31:15 UTC

Hi,

1. git diff: make sure you add an extesion to uploaded patch, eg:
$ git diff >/tmp/topgrade-9.0.1.diff

2. CARGO_CRATES: cargo crates could be in Makefile.crates ('make cargo-crates > Makefile.crates'), instead inside Makefile and don't reformat this list.

3. pkg-plist contain less than 5 files, so it can be included with PLIST_FILES in Makefile

4. this port install examples, consider using EXAMPLES option

Cheers

Created attachment 235510 [details]
topgrade-9.0.1.diff

Hi Nuno,

I created a new patch based on your recommendations (Attachment: topgrade-9.0.1.diff).

Best,
C.

Comment 6 Nuno Teixeira 2022-07-27 21:07:57 UTC

Created attachment 235514 [details]
topgrade-9.0.1 - examples option / fixed formating

- rm LICENSE_FILE= ..LICENSE, its implicit
- add EXAMPLES option
- strip binary
- format pkg-descr to 72 columns

What do you think?

Hi Nuno,

Thank you very much.
The change is fine to me.

Best

Comment 8 Nuno Teixeira 2022-07-28 11:07:57 UTC

Hi,

Could you set approval to '+' on patch details?

Cheers

Comment 9 Nuno Teixeira 2022-07-28 14:05:25 UTC

Before I commit, port maintainer email is 'freebsd@scd-systems.net' and bugzilla's 'c_dornig@gmx.de', could you update bugzilla to maintainer email?

Has been changed

Comment 11 commit-hook 2022-07-28 17:11:46 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f445cb2ae6548c5ec91e72c55fb2a252cc64a6e0

commit f445cb2ae6548c5ec91e72c55fb2a252cc64a6e0
Author:     C <freebsd@scd-systems.net>
AuthorDate: 2022-07-28 17:08:14 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-07-28 17:10:40 +0000

    sysutils/topgrade: New port:  Tool for upgrade everything

     - submitter becomes maintainer

    Upgrade tool for OS and package repositories

    Keeping your system up to date usually involves invoking multiple
    package managers.
    This results in big, non-portable shell one-liners saved in your shell.
    To remedy this, topgrade detects which tools you use and runs the
    appropriate commands to update them

    WWW: https://github.com/r-darwish/topgrade

    PR:             265451

 sysutils/Makefile                       |   1 +
 sysutils/topgrade/Makefile (new)        |  32 +++
 sysutils/topgrade/Makefile.crates (new) | 246 ++++++++++++++++
 sysutils/topgrade/distinfo (new)        | 495 ++++++++++++++++++++++++++++++++
 sysutils/topgrade/pkg-descr (new)       |   9 +
 5 files changed, 783 insertions(+)

Comment 12 Nuno Teixeira 2022-07-28 17:24:53 UTC

I've added:
---
+NOT_FOR_ARCHS= i386
+NOT_FOR_ARCHS_REASON=  failed to run custom build command for `sys-info v0.9.1`
---

and I've opened an issue at:
https://github.com/r-darwish/topgrade/issues/984

Committed, thanks!