Patch is at https://reviews.freebsd.org/D35947 (could not add maintainer as a reviewer in phab so opening a bug as well)
The patch looks fine to me, with the assumption that these changes are needed for it to build with FBSD 14. Should I apply this upstream? (I'm attaching it to the bug as wel)
Created attachment 235500 [details] the actual patch referenced by submitter patch file submitted to phab and referenced by bug submitter (tested)
just to clarify I did a quick test-build with FBSD 12.2 to make sure that the patch did not affect anything below FBSD 14 (it does not appear to). I am pretty sure it would not after looking it over, so now it's just a matter of testing in FBSD 14 which I'll need to do at some point (just not today). If you need anything specific please let me know (thanks). This port is actually needed for earlier FBSD versions that had no ACM (modem class) serial driver, and uses an editable list of USB vendor/product IDs (corresponding to Arduinos that use an AVR USB serial driver, like the Uno and Mega). Since the USB class drivers were added (in 11 I think) it is still useful but its need is less important. I had considered marking it for FBSD versions prior to 11 but it builds/runs ok so I'll continue to maintain it.
Yes, please apply this upstream. I plan to remove the compat shims from 14.0 but am fixing ports first.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=de3758e2e34c09c0b12343f1346aabf1834c8224 commit de3758e2e34c09c0b12343f1346aabf1834c8224 Author: John Baldwin <jhb@FreeBSD.org> AuthorDate: 2022-08-03 22:45:23 +0000 Commit: John Baldwin <jhb@FreeBSD.org> CommitDate: 2022-08-03 22:45:23 +0000 comms/uarduno: Remove devclass from DRIVER_MODULE on recent main. PR: 265458 Reviewed by: Bob Frazier <bobf@mrp3.com> (maintainer) Differential Revision: https://reviews.freebsd.org/D35947 comms/uarduno/files/patch-uarduno.c (new) | 37 +++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)