Created attachment 235618 [details] net/wackamole: fix build on armv7 Jails may not have a bpf(4) device, but can still build with BPF. - fix the configure test for BPF detection - define LICENSE - fix two obvious bugs in the code Tested with Poudriere on armv7 arm64 FreeBSD 13.1. Please MFH if possible.
maintainer timeout
Comment on attachment 235618 [details] net/wackamole: fix build on armv7 maintainer timeout on patch
Hi Robert, files/patches-* were not generated with `make makepatch`. Is there any problem of loosing patches upstream info and use makepatch?
(In reply to Nuno Teixeira from comment #3) (...) And what about include license comment in commit msg only (instead of Makefile)?
(In reply to Nuno Teixeira from comment #4) I did not regenerate existing, pre-makepatch patches to make the diff less noisy. Feel free to change these. > And what about include license comment in commit msg only (instead of Makefile)? I think the comment is valuable to keep in the Makefile. Proceed as you wish.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4d98b01b6fff7b4c1dd36d5f0849ed6dc1f3eb9e commit 4d98b01b6fff7b4c1dd36d5f0849ed6dc1f3eb9e Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-08-16 14:48:13 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-08-16 14:51:50 +0000 net/wackamole: Fix build on armv7 Jails may not have a bpf(4) device, but can still build with BPF. - fix the configure test for BPF detection - define LICENSE - fix two obvious bugs in the code PR: 265561 Approved by: maintainer timeout, >2 weeks MFH: 2022Q3 net/wackamole/Makefile | 7 +++++++ net/wackamole/files/patch-alarm.c | 8 ++++---- net/wackamole/files/patch-arpcache.c (new) | 11 +++++++++++ net/wackamole/files/patch-config_gram.y | 6 +++--- net/wackamole/files/patch-configuration.c | 6 +++--- net/wackamole/files/patch-configure (new) | 11 +++++++++++ net/wackamole/files/patch-defines.h | 11 +++++------ net/wackamole/files/patch-ife-bpf.c (new) | 11 +++++++++++ net/wackamole/files/patch-wackamole.c | 8 ++++---- 9 files changed, 59 insertions(+), 20 deletions(-)
A commit in branch 2022Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cdad97dcc46b2971ef6a2ef632dc688fcc19e5e5 commit cdad97dcc46b2971ef6a2ef632dc688fcc19e5e5 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-08-16 14:48:13 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-08-16 14:53:04 +0000 net/wackamole: Fix build on armv7 Jails may not have a bpf(4) device, but can still build with BPF. - fix the configure test for BPF detection - define LICENSE - fix two obvious bugs in the code PR: 265561 Approved by: maintainer timeout, >2 weeks MFH: 2022Q3 (cherry picked from commit 4d98b01b6fff7b4c1dd36d5f0849ed6dc1f3eb9e) net/wackamole/Makefile | 7 +++++++ net/wackamole/files/patch-alarm.c | 8 ++++---- net/wackamole/files/patch-arpcache.c (new) | 11 +++++++++++ net/wackamole/files/patch-config_gram.y | 6 +++--- net/wackamole/files/patch-configuration.c | 6 +++--- net/wackamole/files/patch-configure (new) | 11 +++++++++++ net/wackamole/files/patch-defines.h | 11 +++++------ net/wackamole/files/patch-ife-bpf.c (new) | 11 +++++++++++ net/wackamole/files/patch-wackamole.c | 8 ++++---- 9 files changed, 59 insertions(+), 20 deletions(-)
(In reply to Robert Clausecker from comment #5) I used makepatch to silence portlint and kept license comment.
Committed, thanks!