Bug 265745 - lang/mono6.8: Fails to build with archivers/brotli installed
Summary: lang/mono6.8: Fails to build with archivers/brotli installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Felix Palmen
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-08-09 19:21 UTC by Felix Palmen
Modified: 2022-08-10 10:09 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (mono)
zirias: merge-quarterly-

Attachments
0001-lang-mono6.8-Fix-build-with-archivers-brotli (1.15 KB, patch)
2022-08-09 19:21 UTC, Felix Palmen 		zirias: maintainer-approval? (mono)
koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen freebsd_committer freebsd_triage 2022-08-09 19:21:00 UTC 
Created attachment 235813 [details]
0001-lang-mono6.8-Fix-build-with-archivers-brotli

See patch (in git-am format). Thanks tcberner for the hint about USES=localbase.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-08-10 00:30:06 UTC 
^Triage: Reporter is committer, assign accordingly
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-08-10 00:31:29 UTC 
Comment on attachment 235813 [details]
0001-lang-mono6.8-Fix-build-with-archivers-brotli

When setting maintainer approval, add the <email address> of maintainer to the value (rather than empty).

Note also, fetch, configure, build, run fixes are:

Approved by: portmgr (blanket: <target> fix), just-fix-it)
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2022-08-10 09:57:12 UTC 
lgtm (as mentor). 

Please note in the commit message, the commit in print/freetype2 which lead to you fixing it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-10 10:08:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1303528e49c7fec9160e60090ca0a2e7713f5294

commit 1303528e49c7fec9160e60090ca0a2e7713f5294
Author:     Felix Palmen <zirias@FreeBSD.org>
AuthorDate: 2022-08-09 18:56:11 +0000
Commit:     Felix Palmen <zirias@FreeBSD.org>
CommitDate: 2022-08-10 10:07:24 +0000

    lang/mono6.8: Fix build with archivers/brotli

    Add USES=localbase, so in-tree headers are found before headers in
    LOCALBASE. This fixes the build with archivers/brotli installed.

    CONFLICTS isn't an option any more, after
    478e294ddedbe6444330b00512a09406265bea71, archivers/brotli is an
    indirect build dependency.

    PR:             265745
    Approved by:    portmgr (build fix blanket), tcberner (mentor)

 lang/mono6.8/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 5 Felix Palmen freebsd_committer freebsd_triage 2022-08-10 10:09:30 UTC 
merge quarterly is not necessary, it doesn't have the commit that caused this build error.