Bug 265907 - x11-wm/awesome: don't require ImageMagick6 for build (either 6 or 7 works fine)
Summary: x11-wm/awesome: don't require ImageMagick6 for build (either 6 or 7 works fine)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-17 16:22 UTC by John Hein
Modified: 2022-08-17 20:18 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rigoletto)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2022-08-17 16:22:31 UTC
ImageMagick6 and ImageMagick7 conflict - they each install some files that are the same (e.g., bin/convert used by the build of x11-wm/awesome).

I built x11-wm/awesome with ImageMagick7 installed, and the port built/installed without any problem.  Given that the built just uses 'convert' to modify some .png files, I think that the restriction for ImageMagick6 specifically can be relaxed.

--- a/x11-wm/awesome/Makefile
+++ b/x11-wm/awesome/Makefile
@@ -26,7 +26,7 @@ LIB_DEPENDS=  libcairo.so:graphics/cairo \

 CONFLICTS_INSTALL=     awesome3

-USES=          cmake compiler:c11 gettext gnome iconv magick:6,build pkgconfig lua \
+USES=          cmake compiler:c11 gettext gnome iconv magick,build pkgconfig lua \
                shebangfix xorg
 USE_GITHUB=    yes
 GH_ACCOUNT=    awesomewm


I don't think PORTREVISION needs to be bumped. ImageMagick7 is the default, but that is only a build dependency. 'convert' could be subtly different between 6 & 7, however, and this could result in slightly different .png files in the package.  One could bump PORTREVISION because of this.  Functionally, there should be no change even if the bits of some files are different.  Given that this is a lightweight package that is easy to build, I might bump PORTREVISION.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-17 20:18:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=99538db3cdb8ed9fbb8a23065e8c55ff2b87b6bb

commit 99538db3cdb8ed9fbb8a23065e8c55ff2b87b6bb
Author:     Alexandre C. Guimarães <rigoletto@FreeBSD.org>
AuthorDate: 2022-08-17 20:14:24 +0000
Commit:     Alexandre C. Guimarães <rigoletto@FreeBSD.org>
CommitDate: 2022-08-17 20:14:24 +0000

    x11-wm/awesome: use default ImageMagick version (7).

    PR:             265907
    Reported by:    John Hein <jcfyecrayz@liamekaens.com>

 x11-wm/awesome/Makefile | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
Comment 2 Alexandre C. Guimarães freebsd_committer freebsd_triage 2022-08-17 20:18:45 UTC
Thank you.