Created attachment 236183 [details] patch for mail/alpine updating to 2.26 - Update to version 2.26 - Update WWW - Some Makefile massaging N.B. That last point causes the patch to be somewhat noisy after a run of portfmt and a bit of reshuffling to pacify portlint/portclippy somewhat. As those changes, while affecting quite a few lines, were pretty mechanical I won't mind if a smaller patch just doing the version bump gets committed.
Created attachment 236341 [details] mail/alpine: update to 2.26 See https://alpineapp.email for the changes.
The patch from Martin looks fine (including the cosmetic changes) but the development of the maildir patch and the alpine version are not in the same pace. I do like the change proposed by Martin but atm it doesn't work because of this. So for now just the alpine update.
Comment on attachment 236183 [details] patch for mail/alpine updating to 2.26 The patch from Martin looks fine (including the cosmetic changes) but the development of the maildir patch and the alpine version are not in the same pace. I do like the change for the maildir patch proposed by Martin but atm it doesn't work because of this. So for now just the alpine update.
Created attachment 236421 [details] mail/alpine: update to 2.26 v1 sugestion: - pet portclippy - pet portfmt - switch to MASTER_SITES= https://alpineapp.email/${PORTNAME}/release/src/ - switch to tar:xz static tarball - remove GIT_COMMIT= 9726c098a739edfdca6218bc5dee104c310957e9 GIT_COMMIT_SHORT= ${GIT_COMMIT:C/^(.......).*/\1/} WRKSRC= ${WRKDIR}/alpine-${GIT_COMMIT_SHORT} - use USES= instead of USES+= - update maildir option/patch to https://alpineapp.email/${PORTNAME}/patches/${DISTNAME}/
(...) - update WWW url to https://alpineapp.email/
(In reply to Nuno Teixeira from comment #4) One minor note regarding MASTER_SITES: For my original submission I considered doing that change as well, but noticed there don't seem to be release tarballs for versions with patchlevel >=1 (or there are, but are clobbering the previous minor version.) With e.g. version 2.24.2 having been in ports, that didn't look purely theoretical either. Personally I'm not terribly invested either way, but want to at least point this out.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=07c5f71db8c5e915b2b8723ffc0d6b7ac68ee5d2 commit 07c5f71db8c5e915b2b8723ffc0d6b7ac68ee5d2 Author: Martin Neubauer <m.ne@gmx.net> AuthorDate: 2022-09-09 10:23:53 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-09 10:25:08 +0000 mail/alpine: Update to 2.26 - update WWW url ChangeLog: https://alpineapp.email/alpine/release/ PR: 266087 mail/alpine/Makefile | 8 ++++---- mail/alpine/distinfo | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-)
Committed, thanks!