Updating GCC_DEFAULT from GCC 11 to GCC 12 is blocked by the fact that building this port with GCC 12 on i386 and amd64 fails. The error message is the following: [ 8% 20/234] /usr/local/bin/g++12 -DRakNetDynamic_EXPORTS -I/wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source -O2 -pipe -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc12 -Wl,-rpath=/usr/local/lib/gcc12 -O2 -pipe -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc12 -Wl,-rpath=/usr/local/lib/gcc12 -fPIC -MD -MT Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/ Source/UDPForwarder.cpp.o -MF Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/Source/UDPForwarder.cpp.o.d -o Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/Source/UDPForwarder.cpp.o -c '/wrkdirs/usr/p orts/devel/raknet/work/raknet-3.9.2_10,1/Source/UDPForwarder.cpp' FAILED: Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/Source/UDPForwarder.cpp.o /usr/local/bin/g++12 -DRakNetDynamic_EXPORTS -I/wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source -O2 -pipe -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc12 -Wl,-rpath=/u sr/local/lib/gcc12 -O2 -pipe -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc12 -Wl,-rpath=/usr/local/lib/gcc12 -fPIC -MD -MT Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/Source/UDPForw arder.cpp.o -MF Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/Source/UDPForwarder.cpp.o.d -o Lib/DLL/CMakeFiles/RakNetDynamic.dir/__/__/Source/UDPForwarder.cpp.o -c '/wrkdirs/usr/ports/devel/rak net/work/raknet-3.9.2_10,1/Source/UDPForwarder.cpp' In file included from /wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source/UDPForwarder.h:13, from /wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source/UDPForwarder.cpp:1: /wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source/DS_Multilist.h: In instantiation of '_IndexType DataStructures::Multilist<_MultilistType, _DataType, _KeyType, _IndexType>::GetIn dexOf(_KeyType) const [with MultilistType _MultilistType = ML_ORDERED_LIST; _DataType = RakNet::UDPForwarder::ForwardEntry*; _KeyType = RakNet::UDPForwarder::SrcAndDest; _IndexType = unsigned int]': /wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source/UDPForwarder.cpp:204:34: required from here /wrkdirs/usr/ports/devel/raknet/work/raknet-3.9.2_10,1/Source/DS_Multilist.h:683:60: error: no match for 'operator==' (operand types are 'DataStructures::MLKeyRef<RakNet::UDPForwarder::SrcAnd Dest>' and 'RakNet::UDPForwarder::ForwardEntry*') 683 | if (MLKeyRef<_KeyType>(key)==data[i]) | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ Please see also the log in the URL field. This URL might be useful to solve the issue: http://gcc.gnu.org/gcc-12/porting_to.html .
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=90030e73f1a76b6d33c68938daa529256313be3b commit 90030e73f1a76b6d33c68938daa529256313be3b Author: Ganael LAPLANCHE <martymac@FreeBSD.org> AuthorDate: 2022-09-08 10:38:55 +0000 Commit: Ganael LAPLANCHE <martymac@FreeBSD.org> CommitDate: 2022-09-08 10:42:22 +0000 devel/raknet: force use of gcc 11 Raknet does not build with gcc 12 because of missing c++ operators, this prevents GCC_DEFAULT bump to 12. As that port is old and un-maintained upstream, just force gcc 11 for now. PR: 266190 Reported by: salvadore devel/raknet/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Hello Lorenzo, Thanks for reporting that issue! Raknet is no more maintained and has been archived upstream, see: https://github.com/facebookarchive/RakNet This port is old and probably nearly useless by now. I have forced GCC to version 11 but we probably want to deprecate it sometime soon or at least when it becomes un-maintainable. Best regards, Ganael.
(In reply to Ganael LAPLANCHE from comment #2) > Raknet is no more maintained and has been archived upstream, see: : > This port is old and probably nearly useless by now. > > I have forced GCC to version 11 but we probably want to deprecate > it sometime soon or at least when it becomes un-maintainable. I believe this time has come: GCC 11 has become unmaintained upstream half a year ago. We already dropped gcc11-devel and gcc11 should follow in the coming months, so I'm thinking to add a deprecation two months out, say. Thoughts?
(In reply to Gerald Pfeifer from comment #3) Hello Gerald, Thanks for taking care of this. Agreed, this software is unmaintained upstream and probably useless by now, so let's deprecate it. Best regards, Ganael.
Thanks for the swift response, Ganael. I'll update the port accordingly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=721f1c601e0990305e2ec6e208ac877c263fee9b commit 721f1c601e0990305e2ec6e208ac877c263fee9b Author: Gerald Pfeifer <gerald@FreeBSD.org> AuthorDate: 2024-11-30 10:39:26 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2024-11-30 10:44:58 +0000 devel/raknet: Deprecate port This is unmaintained upstream and with GCC 11 requires an end-of-life toolchain, so deprecate with an expiration period on 1.5 months. PR: 266190 Approved by: martymac (maintainer) devel/raknet/Makefile | 2 ++ 1 file changed, 2 insertions(+)
(In reply to Gerald Pfeifer from comment #5) Hello Gerald, Thanks a lot! Have a nice week-end, Ganael.