Bug 266195 - x11-drivers/xf86-video-vmware: Fails to build with GCC 12: vmwgfx_tex_video.c:240:20: error: the comparison will always evaluate as 'true' for the address of 'yuv' will never be NULL [-Werror=address]
Summary: x11-drivers/xf86-video-vmware: Fails to build with GCC 12: vmwgfx_tex_video.c...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 (Nobody)
URL: http://pb2.nyi.freebsd.org/data/123i3...
Keywords:
Depends on:
Blocks: 265948
  Show dependency tree / graph
 
Reported: 2022-09-03 09:34 UTC by Lorenzo Salvadore
Modified: 2022-11-08 13:39 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
require-gcc11 (950 bytes, patch)
2022-10-06 20:33 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval? (x11)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2022-09-03 09:34:06 UTC 
Updating GCC_DEFAULT from GCC 11 to GCC 12 is blocked by the fact that building this port with GCC 12 on i386 fails.

The error message is the following:


vmwgfx_tex_video.c: In function 'stop_video':                                                                                                                                                  
vmwgfx_tex_video.c:240:20: error: the comparison will always evaluate as 'true' for the address of 'yuv' will never be NULL [-Werror=address]                                                  
  240 |                if (priv->yuv[i]) {                                                                                                                                                     
      |                    ^~~~


Please see also the log in the URL field. This URL might be useful to solve the issue: http://gcc.gnu.org/gcc-12/porting_to.html .
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-09-21 14:04:33 UTC 
Is there any progress on this bug report? Is there anything I could do to help?

This is one of last three bugs that is blocking the update off GCC default version according to the most recent exp-run. If the bug is complex and requires more time, please also consider setting USE_GCC=11.

Thanks.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-10-06 20:33:06 UTC 
Created attachment 237127 [details]
require-gcc11

I am uploading a patch to require GCC 11 instead of a generic GCC version so that the bug does not block the GCC default version update anymore.

Can someone approve it please?
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-08 13:39:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d221e09d2520f29862decf1d00e7d5dd9ad2fc53

commit d221e09d2520f29862decf1d00e7d5dd9ad2fc53
Author:     Lorenzo Salvadore <salvadore@FreeBSD.org>
AuthorDate: 2022-10-06 20:17:58 +0000
Commit:     Lorenzo Salvadore <salvadore@FreeBSD.org>
CommitDate: 2022-11-08 13:37:24 +0000

    x11-drivers/xf86-video-vmware: Set USE_GCC=11 on i386

    The port requires GCC to build on i386 architectures. As GCC default
    version will soon be updated to version 12, but the port breaks with GCC
    12, we explicitly ask for GCC 11.

    PR:             266195
    Reported by:    exp-run (antoine)
    Approved by:    maintainer timeout (x11, 1 month)

 x11-drivers/xf86-video-vmware/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)