Created attachment 236343 [details] patch pipe-viewer has a .desktop file, but in a different directory than the standard one. It is now a dynamic link to this file, including the icon.
Maintainer informed via mail
Created attachment 236489 [details] pipe-viewer-0.3.1 Description: * add .desktop file * pet portclippy * reformat with portfmt * drop WWW::PipeViewer::Authentication: unused and unsupported * drop WWW::PipeViewer::PlaylistItems::favorite_video: unused and unsupported Changes: https://github.com/trizen/pipe-viewer/blob/0.3.1/Changes QA: * portlint: 1 fatal error and 2 warnings: - FATAL: Makefile: extra item "WWW" placed in the MAINTAINER section. - WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=". - WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=". * poudriere: OK (13-1, amd64, GTK3 JSON_XS LOCAL_CACHE READLINE SHARE_DIR CHAR_WIDTH LINE_BREAK YOUTUBE_DL YT_DL tested)
portlint -C: --- FATAL: ###/ports/multimedia/pipe-viewer/pkg-plist: [39]: this port installs .desktop files. Please add `desktop-file-utils` to USES. --- 6.9.5.2. Updating Desktop Database If a port has a MimeType entry in its portname.desktop, the desktop database must be updated after install and deinstall. To do this, define USES= desktop-file-utils. Cheers
Created attachment 236504 [details] Add GTK3_USES=desktop-file-utils I have added desktop-file-utils to GTK3_USES to update the desktop database only when the GTK3 option is enabled.
(In reply to Jesús Daniel Colmenares Oviedo from comment #4) GTK3_USES=desktop-file-utils make sense since it only installs .desktop files when GTK3 is enabled: --- %%GTK3%%%%SITE_PERL%%/auto/share/dist/WWW-PipeViewer/gtk-pipe-viewer.desktop %%GTK3%%share/applications/gtk-pipe-viewer.desktop --- I think I will open an issue at portlint about this. Cheers
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ae5b7072886eb9e743c22f814a85f46722b0d4f4 commit ae5b7072886eb9e743c22f814a85f46722b0d4f4 Author: Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org> AuthorDate: 2022-09-11 23:24:54 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-11 23:24:54 +0000 multimedia/*pipe-viewer: Update to 0.3.1 - add .desktop file - pet portclippy - reformat with portfmt - drop WWW::PipeViewer::Authentication: unused and unsupported - drop WWW::PipeViewer::PlaylistItems::favorite_video: unused and unsupported ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.3.1/Changes PR: 266208 multimedia/gtk-pipe-viewer/Makefile | 4 ++-- multimedia/pipe-viewer/Makefile | 34 ++++++++++++++++++++-------------- multimedia/pipe-viewer/distinfo | 6 +++--- multimedia/pipe-viewer/pkg-plist | 7 +++---- 4 files changed, 28 insertions(+), 23 deletions(-)
Committed, thanks!