Bug 266299 - multimedia/ffmpeg: fix build with SDL option enabled
Summary: multimedia/ffmpeg: fix build with SDL option enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Stefan Eßer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-08 12:02 UTC by Martin Neubauer
Modified: 2022-09-19 10:55 UTC (History)
8 users (show)

See Also:
fernape: maintainer-feedback? (multimedia)

Attachments
patch adding upstream fix for sdl's new versioning scheme (780 bytes, patch)
2022-09-08 12:02 UTC, Martin Neubauer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2022-09-08 12:02:41 UTC 
Created attachment 236438 [details]
patch adding upstream fix for sdl's new versioning scheme

After the recent update of devel/sdl20 ffmpeg didn't build any more. Upstream already handled this in https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/e5163b1d3438 .
Comment 1 david 2022-09-13 13:31:10 UTC 
Thanks to this patch, I was able to upgrade ffmpeg-4.4.2_7,1 to ffmpeg-4.4.2_8,1 (with ports at main-n595527-37d7b006414e).
Comment 2 Chad Jacob Milios 2022-09-15 11:45:48 UTC 
works for me on FreeBSD-13.1-RELEASE-amd64. thank you
Comment 3 Kevin Reinholz 2022-09-18 15:40:41 UTC 
The same error persists with ffmpeg-4.4.2_9,1

The same fix allows it to build with the sdl option enabled.
Comment 4 Ivan Rozhuk 2022-09-18 22:42:21 UTC 
Work for me. Thanks!
Comment 5 Stefan Eßer freebsd_committer freebsd_triage 2022-09-19 07:24:58 UTC 
(In reply to Ivan Rozhuk from comment #4)

Since this is a patch that has already applied to the ffmpeg upstream, we should either apply this patch or upgrade to an fixed upstream version.

I'll commit the patch under the "just fix it" exception granted by portmgr, it can be removed by the maintainers when ffmpeg is upgraded to a fixed version.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-09-19 07:44:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=906df1b6f2587c491a86391cea3f1870b0e16977

commit 906df1b6f2587c491a86391cea3f1870b0e16977
Author:     Martin Neubauer <m.ne@gmx.net>
AuthorDate: 2022-09-19 07:38:15 +0000
Commit:     Stefan Eßer <se@FreeBSD.org>
CommitDate: 2022-09-19 07:42:43 +0000

    multimedia/ffmpeg: fix build with SDL option enabled

    Since this is a patch that has already applied to the ffmpeg upstream,
    we should either apply this patch or upgrade to an fixed upstream
    version, see:

    https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/e5163b1d3438

    This issue has existed for some time and despite the port being
    upgraded in between, therefore I'll commit the patch under the
    "just fix it" exception granted by portmgr, it can be removed by
    the maintainers when ffmpeg is upgraded to a fixed version.

    PR:             266299
    Reported by:    m.ne@gmx.net (Martin Neubauer)
    Approved by:    portmgr (implicit)

 multimedia/ffmpeg/files/patch-configure | 9 +++++++++
 1 file changed, 9 insertions(+)
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-19 10:55:48 UTC 
^Triage: assign to committer who resolved the issue.

Closing since it doesn't seem necessary to MFH being so close to creating Q4.