Created attachment 236452 [details]
patch update: remove remote option, blank removed files.

1. REMOTE option has been removed from the upstream (https://github.com/myriadrf/LimeSuite/issues/366), removing port option.
2. Blank removed files for use with patch -E.

Comment 2 Kurt Jaeger 2022-09-09 16:52:51 UTC

testbuilds@work

Comment 3 Kurt Jaeger 2022-09-09 19:08:36 UTC

(In reply to Kurt Jaeger from comment #2)
The patchfile fails to patch the port Makefile somehow:

Patching file Makefile using Plan A...
Hunk #1 failed at 1.
Hunk #2 failed at 23.
Hunk #3 failed at 62.
3 out of 3 hunks failed--saving rejects to Makefile.rej

Can you try to update the patch ?

Created attachment 236461 [details]
diff -ruN comms/limesuite comms/limesuite-22.09.0

diff -ruN comms/limesuite comms/limesuite-22.09.0
sorry :-)

Comment 5 Kurt Jaeger 2022-09-10 07:31:56 UTC

Committed,thanks!

Comment 6 commit-hook 2022-09-10 07:32:26 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a69f092f0d9b1012bbc10dbe5546bc8f6ed989bd

commit a69f092f0d9b1012bbc10dbe5546bc8f6ed989bd
Author:     Tomasz "CeDeROM" CEDRO <tomek@cedro.info>
AuthorDate: 2022-09-10 07:28:25 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2022-09-10 07:28:25 +0000

    comms/limesuite: update 20.10.0 -> 22.09.0

    - REMOTE option has been removed, because upstream dropped the feature
      (https://github.com/myriadrf/LimeSuite/issues/366)

    PR:             266307
    Changes:        https://github.com/myriadrf/LimeSuite/blob/master/Changelog.txt

 comms/limesuite/Makefile                           | 48 ++++++-----
 comms/limesuite/distinfo                           |  6 +-
 comms/limesuite/files/patch-CMakeLists.txt (gone)  | 14 ----
 .../files/patch-Desktop_CMakeLists.txt (gone)      | 19 -----
 ...rc_ConnectionRemote_ConnectionRemote.cpp (gone) | 13 ---
 ...TREAM__UNITE_ConnectionSTREAM__UNITE.cpp (gone) | 10 ---
 ...__UNITE_ConnectionSTREAM__UNITEEntry.cpp (gone) | 11 ---
 ...Acontrols__wxgui_FPGAcontrols__wxgui.cpp (gone) | 11 ---
 comms/limesuite/pkg-plist                          | 96 ++++++----------------
 9 files changed, 55 insertions(+), 173 deletions(-)

TANK U SIR! =)

Created attachment 236491 [details]
Updates version name to use "v" prefix.

Just a remark, I got a message from Portscout that did not recognise version correctly (22.09.0 vs v22.09.0). Patch is attached. That should fix the issue :-)


Port                                            | Current version | New version
------------------------------------------------+-----------------+------------
comms/limesuite                                 | 22.09.0         | v22.09.0
------------------------------------------------+-----------------+------------

Sorry, negative, that does not solve the problem, and produces build issues.

I do not know how to fix the missing prefix in a good way.

Please advise or we leave as is..?

Comment 10 Kurt Jaeger 2022-09-11 17:20:29 UTC

(In reply to Tomasz "CeDeROM" CEDRO from comment #9)
I have to search for a solution as well, don't know the cause...

The most important part is done, new version is out there ready for use, thank you Pi for your time and support! :-)