Created attachment 236545 [details] various improvements v0 This is a sample of next updates on aws* and other cmake ports. Commit msg: --- - Define LICENSE_FILE - Add ports framework for unit testing - Use CMake helpers provided by framework - Remove unneeded CFLAGS+=-D__BSD_VISIBLE=1 since: ${WRKSRC}/source/posix/system_info.c: --- #if defined(__FreeBSD__) || defined(__NetBSD__) # define __BSD_VISIBLE 1 #endif --- - bumping PORTREVISION --- doubts: - not sure about bumping PORTREVISION since build is untouched but LICENSE_FILE was added and __BSD_VISIBLE removed - not really really sure about __BSD_VISIBLE but no build problems - add cmake:testing works fine Any hints or fixes? Cheers
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=81bfc9d8d06bf0a384232ef5ba4a9fc42a7324d4 commit 81bfc9d8d06bf0a384232ef5ba4a9fc42a7324d4 Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2022-09-15 12:06:09 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-15 12:14:18 +0000 devel/aws-c-common: port improvements - Define LICENSE_FILE - Use ports framework for unit testing - Use CMake helpers provided by framework - Remove unneeded CFLAGS+=-D__BSD_VISIBLE=1 since: ${WRKSRC}/source/posix/system_info.c: --- #if defined(__FreeBSD__) || defined(__NetBSD__) # define __BSD_VISIBLE 1 #endif --- - Not bumping PORTREVISION PR: 266405 devel/aws-c-common/Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
Committed without bumping PORTREVISION
LGTM, you're too fast ;-)
(In reply to Daniel Engberg from comment #3) When I got doubts about a commit I always open a PR and it helps me reflect about it and ofc to ask for help and opinions. I did committed fast because in the meanwhile I cleared my doubts. BTW, I've got a very nice answer about LICENSE_FILE at ports@: https://lists.freebsd.org/archives/freebsd-ports/2022-September/002699.html Thanks :)