Bug 266447 - devel/llvm-devel: check-sanity fails on check of COMPILER_RT_LIBS
Summary: devel/llvm-devel: check-sanity fails on check of COMPILER_RT_LIBS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-16 14:58 UTC by John Hein
Modified: 2022-09-16 17:34 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2022-09-16 14:58:09 UTC 
After commit eb0de48b (Sep 16), devel/llvm-devel fails check-sanity in developer mode:

% make DEVELOPER=yes check-sanity
/!\ llvm-devel-16.0.d20220915: Makefile errors /!\

The following options helpers are incorrectly set after bsd.port.options.mk
and are ineffective: COMPILER_RT_LIBS


There may be a case that this is a bsd.sanity.mk deficiency.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-09-16 17:30:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=25e93187069e74c4050dd39f1f38075a8b597b2c

commit 25e93187069e74c4050dd39f1f38075a8b597b2c
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2022-09-16 17:27:03 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2022-09-16 17:28:52 +0000

    devel/llvm-devel: fix name collision

    Use _COMPILER_RT_LIBS rather than COMPILER_RT_LIBS for the list of
    library paths installed by the COMPILER_RT option.  This worked because
    it was added after bsd.port.options.mk, but triggered a bsd.sanity.mk
    warning.

    PR:             266447

 devel/llvm-devel/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)