Bug 266465 - mail/exim: 4.95 breaks alternative SRS
Summary: mail/exim: 4.95 breaks alternative SRS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-17 18:41 UTC by Chris Collins
Modified: 2023-11-09 07:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (fluffy)

Attachments
options and Makefile patches to add support for OLD_SRS, split them (1.37 KB, patch)
2022-09-17 18:41 UTC, Chris Collins 		no flags Details | Diff
Makefile patch (562 bytes, patch)
2022-09-17 18:43 UTC, Chris Collins 		no flags Details | Diff
Adds support for OLD_SRS on options (836 bytes, patch)
2022-09-17 18:44 UTC, Chris Collins 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Collins 2022-09-17 18:41:35 UTC 
Created attachment 236639 [details]
options and Makefile patches to add support for OLD_SRS, split them

A previous Exim patch removed support for Alternative SRS, however this is still maintained by upstream.

These patches for 'options' and 'Makefile' adds support back without removing the previous change to support the new implementation.  It also doesnt change the default.

I am merging both patches into one on here as only one seems to be supported on the bug report. So they will need to be split to be used.

Previous bug report here.  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260789
Comment 1 Chris Collins 2022-09-17 18:43:11 UTC 
Created attachment 236640 [details]
Makefile patch

Adds compiler flags and lib depends for alternative SRS, these are not quite the same as the original flags which are no longer valid.
Comment 2 Chris Collins 2022-09-17 18:44:10 UTC 
Created attachment 236641 [details]
Adds support for OLD_SRS on options

Adds support for older SRS implementation without removing the new one or changing defaults.
Comment 3 Chris Collins 2022-09-17 18:48:20 UTC 
I attached both patches separately now.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2023-04-10 10:28:35 UTC 
Do those patches apply to 4.96 as well ?
Comment 5 Chris Collins 2023-04-12 17:57:22 UTC 
Yes it should be fine, it doesnt actually patch exim itself, just the ports Makefile and Options file, I checked the 4.96 changelog and there is nothing there to remove support for it.
Comment 6 Chris Collins 2023-04-12 17:59:34 UTC 
Also checked 4.97 changelog and it should be fine for that version as well.
Comment 7 Chris Collins 2023-04-12 18:06:05 UTC 
I use the quarterly ports tree of which it still applies fine but thats 4.95_6, if your concern is about does it apply to the 4.96 ports version I will test it in a VM to confirm its ok.
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2023-11-08 17:12:35 UTC 
testbuild@work
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2023-11-09 07:05:38 UTC 
Committed, thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-11-09 07:06:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2ce476eea4a37b1735316edc26a5d8df2bb3e48e

commit 2ce476eea4a37b1735316edc26a5d8df2bb3e48e
Author:     Chris Collins <chrysalis@chrysalisnet.org>
AuthorDate: 2023-11-09 07:03:17 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2023-11-09 07:03:17 +0000

    mail/exim: re-add support for Alternative SRS

    PR:             266465
    Approved by:    fluffy (maintainer, implicit)
    Author:         Chris Collins <chrysalis@chrysalisnet.org>

 mail/exim/Makefile | 4 ++++
 mail/exim/options  | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)