Bug 266511 - databases/mysql80-server: Update my.cnf.sample
Summary: databases/mysql80-server: Update my.cnf.sample
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-20 07:53 UTC by mark burdett
Modified: 2022-10-29 15:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
Update deprecated configs in my.cnf.sample (1.69 KB, patch)
2022-09-20 07:53 UTC, mark burdett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mark burdett 2022-09-20 07:53:43 UTC
Created attachment 236695 [details]
Update deprecated configs in my.cnf.sample

Some configs in my.cnf.sample are now deprecated. These should be replaced with their replacement, or removed if there is no replacement.

- Replace deprecated slave-load-tmpdir with replica-load-tmpdir
- Remove deprecated master-info-repository (it was set to the default)
- Remove deprecated relay-log-info-repository (it was set to the default)
- Replace deprecated expire_logs_days with binlog_expire_logs_seconds (multiply 30 days by 24 * 60 * 60)
- Replace deprecated innodb_log_file_size with innodb_redo_log_capacity (preserving the same configured capacity, which was set to 256M * 2 log files)
- Remove deprecated skip-symbolic-links (it is the default)
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2022-09-20 08:18:10 UTC
good point that I overlooked. Thanks.
I'll take a closer look at it as soon as possible and commit it
Comment 2 Christos Chatzaras 2022-09-20 14:51:02 UTC
(In reply to mark burdett from comment #0)

"Deprecated" means that they will remove it in a future version and for now we can still use the old variable names, right?
Comment 3 mark burdett 2022-09-20 18:09:43 UTC
Yes this is very low priority as nothing is broken. The idea here was just that the sample configs shouldn't be logging warnings to the error log.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-29 15:08:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1bc699507caeb6807ec13443074567da4c847596

commit 1bc699507caeb6807ec13443074567da4c847596
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2022-10-29 15:07:07 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2022-10-29 15:08:22 +0000

    databases/mysql80-server: Update my.cnf.sample

    Update deprecated configs in my.cnf.sample

    Some configs in my.cnf.sample are now deprecated. These should be replaced with their replacement, or removed if there is no replacement.

    - Replace deprecated slave-load-tmpdir with replica-load-tmpdir
    - Remove deprecated master-info-repository (it was set to the default)
    - Remove deprecated relay-log-info-repository (it was set to the default)
    - Replace deprecated expire_logs_days with binlog_expire_logs_seconds (multiply 30 days by 24 * 60 * 60)
    - Replace deprecated innodb_log_file_size with innodb_redo_log_capacity (preserving the same configured capacity, which was set to 256M * 2 log files)
    - Remove deprecated skip-symbolic-links (it is the default)

    PR:     266511
    Sponsored by:   Netzkommune GmbH

 databases/mysql80-server/files/my.cnf.sample.in | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)