Bug 266637 - graphics/okular build fails with PURPOSE=OFF; "REQUIRED packages have not been found: KF5Purpose"
Summary: graphics/okular build fails with PURPOSE=OFF; "REQUIRED packages have not bee...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: https://pkg.thu.de.rostwald.de/logs/b...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-26 19:58 UTC by Sebastian
Modified: 2022-09-27 10:17 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian 2022-09-26 19:58:51 UTC
Building graphics/okular from 'latest' ports tree on 12.3-RELEASE with PURPOSE=OFF fails due to KF5purpose still being considered 'required' during the build process. 

(taken from poudriere log)
---Begin OPTIONS List---

===> The following configuration options are available for okular-22.08.1_1:

     DOCS=on: Build and/or install documentation

     PURPOSE=off: Enable 'Share' menu

===> Use 'make config' to modify these settings

---End OPTIONS List---
[...]
-- The following REQUIRED packages have not been found:

 * KF5Purpose, A framework for services and actions integration
   Required for enabling the share menu. You can make the dependency optional adding KF5Purpose to the FORCE_NOT_REQUIRED_DEPENDENCIES cmake option

CMake Error at /usr/local/share/cmake/Modules/FeatureSummary.cmake:464 (message):
  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
  run.
Call Stack (most recent call first):
  CMakeLists.txt:649 (feature_summary)
[...]


According to the makefile, KF5purpose is not a dependency:

BUILD_DEPENDS=  markdown:textproc/discount
RUN_DEPENDS=    markdown:textproc/discount
LIB_DEPENDS=    libchm.so:misc/chmlib \
        libdjvulibre.so:graphics/djvulibre \
        libepub.so:textproc/ebook-tools \
        libfreetype.so:print/freetype2 \
        libqmobipocket.so:graphics/kdegraphics-mobipocket \
        libpoppler.so:graphics/poppler \
        libpoppler-qt5.so:graphics/poppler-qt5 \
        libspectre.so:print/libspectre \
        libtiff.so:graphics/tiff \
        libzip.so:archivers/libzip


This is reproducible on 2 different 12.3-RELEASE hosts and with either poudriere or running 'make config && make build' in the ports tree.
I could not test/verify on 13.1-RELEASE because I don't have a 13.1 host that follows latest; current version in quarterly/2022Q3 is 22.04.3_1, which successfully builds.

According to my poudriere logs, this has been the case since (at least) version 22.08.0_1 (first failed build); the last successful build was 22.04.3_4.
I'm not rebuilding very regularly, so sometimes there are 2 or 3 weeks in between and I might have skipped some intermediate versions.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-09-27 10:12:31 UTC
(In reply to Sebastian from comment #0)
moin moin 

Thanks for the report -- the Cmake-Findcall changed a while a go, and we never updated the disable bool 

Makefile:
PURPOSE_CMAKE_BOOL_OFF=├CMAKE_DISABLE_FIND_PACKAGE_KDEExperimentalPurpose

This should be adapted to read KF5Purpose

Will fix.

mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-09-27 10:16:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4bd2c490cb91a29c5b66dc8f896d683a8b29e337

commit 4bd2c490cb91a29c5b66dc8f896d683a8b29e337
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-09-27 10:13:35 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-09-27 10:13:35 +0000

    graphics/okular: fix PURPOSE option's CMAKE_ARGS

    The cmake package was renamed a while ago, so this had been broken for a
    while technically. However with the latest release the optional
    dependencies have been made required by default, leading to it now
    actually erroring out in this case.

    Reported by:    Sebastian <sko@rostwald.de>
    PR:             266637

 graphics/okular/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)