Bug 266907 - emulators/virtualbox-ose{-*}: Update to 6.1.44
Summary: emulators/virtualbox-ose{-*}: Update to 6.1.44
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Vladimir Druzenko
URL: https://www.virtualbox.org/wiki/Chang...
Keywords: security
Depends on:
Blocks:
 
Reported: 2022-10-08 16:39 UTC by Ian Dickens
Modified: 2023-05-26 12:35 UTC (History)
14 users (show)

See Also:
koobs: maintainer-feedback? (vbox)
grahamperrin: maintainer-feedback? (vvd)
joneum: merge-quarterly+


Attachments
update to 6.1.40 (3.33 KB, patch)
2022-11-08 21:14 UTC, imbutler
no flags Details | Diff
patch to update to 6.1.42 (3.33 KB, patch)
2023-02-08 16:15 UTC, imbutler
no flags Details | Diff
updated patch for 6.1.42 (4.20 KB, patch)
2023-02-12 17:46 UTC, Li-Wen Hsu
no flags Details | Diff
emulators/virtualbox-ose-6.1.44 (4.11 KB, patch)
2023-04-19 14:29 UTC, groenveld
no flags Details | Diff
virtualbox-ose-6.1.44.log (64.19 KB, text/plain)
2023-04-19 22:47 UTC, Graham Perrin
no flags Details
emulators/virtualbox-ose-6.1.44 (4.36 KB, patch)
2023-04-20 03:07 UTC, groenveld
no flags Details | Diff
emulators/virtualbox-ose-6.1.44 (4.36 KB, patch)
2023-04-20 14:25 UTC, groenveld
no flags Details | Diff
error log (952.97 KB, text/plain)
2023-04-21 00:28 UTC, Graham Perrin
no flags Details
emulators/virtualbox-ose-6.1.44 2023-04-29 09:48 (4.41 KB, patch)
2023-04-29 09:48 UTC, Graham Perrin
no flags Details | Diff
emulators/virtualbox-ose-6.1.44 2023-04-30 00:49 (4.37 KB, patch)
2023-04-29 23:55 UTC, Graham Perrin
no flags Details | Diff
update to 6.1.44 (for 12.x and 13.x) (4.23 KB, patch)
2023-05-10 21:20 UTC, Vladimir Druzenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Dickens 2022-10-08 16:39:52 UTC
The latest version of Virtualbox is 6.1.38 and it's been out for a while now on other platforms.  I managed to compile this on my local poudriere build server without any changes to patches and it's been up and running on my DMZ hypervisor for a few weeks now without any issues so far.  I should mention that all the VMs there are headless.  But still it all seems to be working smoothly for me so far.

Version bump is needed...

Thanks,

Ian
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-10-08 17:48:14 UTC
Thanks. 

Recalling bug 265351 comment 1, I think it likely that someone is already working towards updating the non-legacy ports …
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2022-10-09 02:34:36 UTC
madpilot is not working on vbox currently.
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-10-09 08:01:24 UTC
(In reply to Li-Wen Hsu from comment #2)

Thanks, and my apologies to madpilot@ for the false assumption.
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2022-10-09 08:26:36 UTC
To elaborate, I've stopped using it, I migrated to bhyve and I'm having a much better experience for what I'm using it for. I personally suggest anyone needing virtualization under FreeBSD takes a look at it. YMMV.

Due to this I don't have virtualbox installed on any machine anymore and I'm unable to test patches or do any updates for this port.
Comment 5 DutchBSD 2022-10-09 21:01:04 UTC
Guido Falsi bhyve is not golden, sad to see virtualbox-ose gets some lesser attention. choices are a good thing of course. I hope someone is willing to upgrade the ports.
Comment 6 Ian Dickens 2022-10-10 16:56:05 UTC
(In reply to Dutchman01 from comment #5
I am reminded of RedHat's RHEV and what a whole disaster that was....  And while bhyve is wonderfull for freebsd - it's not platform agnostic and AFAICT there is no import/export of things to ova/ovf ( I rely heavily on that for offline backups and quick restoration of VMS).  IDK - Maybe bhyve could suit me better for for now the best choice for my virt host is ubuntu and virtualbox.
Comment 7 Graham Perrin freebsd_committer freebsd_triage 2022-10-10 21:58:39 UTC
Respectfully: 

* for this bug 266907, let's focus on technical aspects of an update

* general discussion of virtualisation will be better in an area such as 
  <https://lists.freebsd.org/subscription/freebsd-virtualization>

– thank you.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-13 05:22:06 UTC
(In reply to Guido Falsi from comment #4)
I have 4 hosts with Bloomfields - i7 920/930. And as soon as bhyve supports Bloomfield, I will switch to it.
Comment 9 Graham Perrin freebsd_committer freebsd_triage 2022-10-13 14:49:42 UTC
Back on topic, VirtualBox (not bhyve): 

<https://www.virtualbox.org/wiki/Changelog-7.0>
Comment 10 Ian Dickens 2022-10-13 22:39:21 UTC
After using virtualbox 7.0 for a few days now I can say that not having to launch multiple instances of the app to do multiple exports/imports is really nice.

$.02

Ian
Comment 11 Graham Perrin freebsd_committer freebsd_triage 2022-10-14 04:17:57 UTC
Triage: reset the importance, to what's normal for updates. 

(In this context, two people does not equal some.)

Thanks to koobs@ for the hint.
Comment 12 Li-Wen Hsu freebsd_committer freebsd_triage 2022-10-14 07:41:45 UTC
(In reply to Ian Dickens from comment #10)
Do you have version 7.0 compiled as 6.1.38 you mentioned? If so, is it possible for you to share the patch with others to test? And maybe we can even use it to update the virtualbox ports.
Comment 13 imbutler 2022-11-08 21:14:30 UTC
Created attachment 237957 [details]
update to 6.1.40

The attached (minimal) patch updates virtualbox from 6.1.38 to 6.1.40
I have not tested a compiled additions package on a guest
Comment 14 imbutler 2022-11-08 21:21:24 UTC
(In reply to imbutler from comment #13)

Sorry, I meant "from 6.1.36" ..
Comment 15 Cy Schubert freebsd_committer freebsd_triage 2022-11-20 14:06:12 UTC
7.0.4 is out.
Comment 16 DutchBSD 2022-12-11 20:41:22 UTC
6.1.40 runs perfectly fine!

please update ports
Comment 17 imbutler 2023-02-08 16:15:33 UTC
Created attachment 240000 [details]
patch to update to 6.1.42
Comment 18 Li-Wen Hsu freebsd_committer freebsd_triage 2023-02-12 17:46:15 UTC
Created attachment 240110 [details]
updated patch for 6.1.42

Fix the pkg-plist and out of date PORTVERSION in emulators/virtualbox-ose-additions
Comment 19 Li-Wen Hsu freebsd_committer freebsd_triage 2023-02-12 17:48:00 UTC
(In reply to Li-Wen Hsu from comment #18)
I currently can only do build test of this in poudriere, please let me know if this runs fine.
Comment 20 groenveld 2023-04-18 13:58:09 UTC
(In reply to Li-Wen Hsu from comment #19)

Worked with CURRENT
$ uname -srvKU
FreeBSD 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n262010-f21faa67ab6b: Thu Apr  6 07:56:57 UTC 2023     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC 1400085 1400085
$ VBoxManage --version
6.1.42r155177

John
groenveld@acm.org
Comment 21 groenveld 2023-04-18 14:49:09 UTC
(In reply to Li-Wen Hsu from comment #19)

Worked with 13.2-RELEASE:

$ uname -srvKU
FreeBSD 13.2-RELEASE FreeBSD 13.2-RELEASE releng/13.2-n254617-525ecfdad597 GENERIC 1302001 1302001

$ VBoxManage --version
6.1.42r155177

John
groenveld@acm.org
Comment 23 groenveld 2023-04-19 14:29:56 UTC
Created attachment 241586 [details]
emulators/virtualbox-ose-6.1.44
Comment 24 Graham Perrin freebsd_committer freebsd_triage 2023-04-19 22:47:48 UTC
Created attachment 241600 [details]
virtualbox-ose-6.1.44.log

Thank you, 

(In reply to groenveld from comment #23)

Build of emulators/virtualbox-ose failed to configure. 

Maybe relevant: 

% pkg iinfo llvm
llvm15-15.0.7_3
llvm16-16.0.1
% 

– no llvm14. I'll install then retry the build.
Comment 25 Cy Schubert freebsd_committer freebsd_triage 2023-04-19 22:54:16 UTC
Does someone have a patch for 7.0.8?
Comment 26 Graham Perrin freebsd_committer freebsd_triage 2023-04-19 23:00:14 UTC
(In reply to Graham Perrin from comment #24)

> … – no llvm14. I'll install then retry the build.

Done: 

% pkg iinfo llvm
llvm14-14.0.6
llvm15-15.0.7_3
llvm16-16.0.1
% uname -aKU
FreeBSD mowa219-gjp4-8570p-freebsd 14.0-CURRENT FreeBSD 14.0-CURRENT #38 main-n262032-5e2e3615d91f: Fri Apr  7 18:54:28 BST 2023     grahamperrin@mowa219-gjp4-8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64 1400085 1400085
% 

----

Again, configuration failed. 

The tail of the error log: 

==>  Configuring for virtualbox-ose-6.1.44
Checking for environment: Determined build machine: freebsd.amd64, target machine: freebsd.amd64, OK.
Checking for kBuild: found, OK.
Checking for gcc: 
  ** /usr/local/llvm14/bin/clang (variable CC) not found!
Check /wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/configure.log for details
===>  Script "configure" failed unexpectedly.
Please report the problem to vbox@FreeBSD.org [maintainer] and attach the
"/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/emulators/virtualbox-ose
=>> Cleaning up wrkdir
sh: /usr/local/llvm14/bin/clang: not found
make: "/usr/ports/Mk/Uses/compiler.mk" line 80: warning: "/usr/local/llvm14/bin/clang --version" returned non-zero status
make: "/usr/ports/Mk/Uses/compiler.mk" line 128: warning: "/usr/local/llvm14/bin/clang++ -### /dev/null 2>&1" returned non-zero status
sh: /usr/local/llvm14/bin/clang: not found
make[1]: "/usr/ports/Mk/Uses/compiler.mk" line 80: warning: "/usr/local/llvm14/bin/clang --version" returned non-zero status
make[1]: "/usr/ports/Mk/Uses/compiler.mk" line 128: warning: "/usr/local/llvm14/bin/clang++ -### /dev/null 2>&1" returned non-zero status
===>  Cleaning for virtualbox-ose-6.1.44
sh: /usr/local/llvm14/bin/clang: not found
make[1]: "/usr/ports/Mk/Uses/compiler.mk" line 80: warning: "/usr/local/llvm14/bin/clang --version" returned non-zero status
make[1]: "/usr/ports/Mk/Uses/compiler.mk" line 128: warning: "/usr/local/llvm14/bin/clang++ -### /dev/null 2>&1" returned non-zero status
build of emulators/virtualbox-ose | virtualbox-ose-6.1.44 ended at Wed Apr 19 23:57:12 BST 2023
build time: 00:06:59
!!! build failure encountered !!!
^C
Comment 27 groenveld 2023-04-20 01:44:50 UTC
(In reply to Graham Perrin from comment #26)

# pkg which /usr/local/llvm14/bin/clang
/usr/local/llvm14/bin/clang was installed by package llvm14-14.0.6

John
groenveld@acm.org
Comment 28 groenveld 2023-04-20 03:00:43 UTC
(In reply to groenveld from comment #23)


Updated the patch with the FreeBSD 14 conditional to specify llvm14.
John
groenveld@acm.org
Comment 29 groenveld 2023-04-20 03:07:51 UTC
Created attachment 241606 [details]
emulators/virtualbox-ose-6.1.44

with FreeBSD version conditional to specify llvm14 for FreeBSD 14.
John
groenveld@acm.org
Comment 30 Benjamin Takacs 2023-04-20 06:27:36 UTC
(In reply to groenveld from comment #29) 

Why does virtualbox-ose now need clang14? Why is that dependency not handled via USES=compiler:…? I don't see changed USES=compiler:… or added dependency on llvm14, so where should clang14 come from?
Comment 31 groenveld 2023-04-20 10:58:30 UTC
(In reply to Benjamin Takacs from comment #30)

Using llvm14 is a hack for Bug 270189 on CURRENT.
John
groenveld@acm.org
Comment 32 groenveld 2023-04-20 14:25:47 UTC
Created attachment 241618 [details]
emulators/virtualbox-ose-6.1.44

patch including the llvm14 package dependency for the CURRENT hack.
John
groenveld@acm.org
Comment 33 Graham Perrin freebsd_committer freebsd_triage 2023-04-21 00:28:51 UTC
Created attachment 241626 [details]
error log

(In reply to groenveld from comment #32)

Build failed.
Comment 34 groenveld 2023-04-21 00:52:43 UTC
(In reply to Graham Perrin from comment #33)

What happens when you try to build without using Poudriere automation?

Not sure why Poudriere is not respecting BUILD_DEPENDS+= clang14:devel/llvm14.
John
groenveld@acm.org
Comment 35 Graham Perrin freebsd_committer freebsd_triage 2023-04-21 05:58:32 UTC
(In reply to groenveld from comment #34)

From the head of the log, does this help? 

=>> Building emulators/virtualbox-ose
sh: clang14: not found
make: "/usr/ports/Mk/Uses/compiler.mk" line 80: warning: "clang14 --version" returned non-zero status
make: "/usr/ports/Mk/Uses/compiler.mk" line 128: warning: "clang++14 -### /dev/null 2>&1" returned non-zero status



----

The run of poudriere did include a build of llvm14 (around six hours and twenty minutes): 

% pwd 
/usr/local/poudriere/data/logs/bulk/main-default/2023-04-20_18h20m40s/logs
% ls -hln
total 1
drwxr-xr-x  2 0  0     3B 21 Apr 00:53 errors
-rw-r--r--  3 0  0    20M 21 Apr 00:44 llvm14-14.0.6.log
-rw-r--r--  3 0  0   953K 21 Apr 00:54 virtualbox-ose-6.1.44.log
% 



----

make.conf files contents: 

% grep -v \# /etc/make.conf | sort
…
 
CFLAGS+= -O3 -pipe -march=native -mtune=native
WITH_CCACHE_BUILD=yes
WITH_DEBUG_PORTS=multimedia/webcamd
WITHOUT_LLVM_ASSERTIONS=
% grep -v \# /usr/local/etc/poudriere.d/make.conf | sort
…

CFLAGS+= -O3 -pipe -march=native -mtune=native
ICA_CERTS=QuoVadisEuropeEVSSLCAG1.crt
LICENSES_ACCEPTED += commercial
WITH_DEBUG_PORTS=ports-mgmt/pkg
WITHOUT_LLVM_TARGET_ALL=
%
Comment 36 Graham Perrin freebsd_committer freebsd_triage 2023-04-26 05:44:03 UTC
(In reply to groenveld from comment #32)

Please, can you update the patch? 

With a current copy of the ports repo, the patch no longer applies: 

% gh repo sync grahamperrin/freebsd-ports && git -C /usr/ports pull --ff-only freebsd main && git -C /usr/ports pull --ff-only
✓ Synced the "grahamperrin:main" branch from "freebsd:main"
From https://git.freebsd.org/ports
 * branch                      main       -> FETCH_HEAD
Already up to date.
Already up to date.
% git -C /usr/ports apply --check /tmp/266907c32.diff
error: patch failed: emulators/virtualbox-ose-additions/Makefile:1
error: emulators/virtualbox-ose-additions/Makefile: patch does not apply
error: patch failed: emulators/virtualbox-ose-kmod/Makefile:1
error: emulators/virtualbox-ose-kmod/Makefile: patch does not apply
error: patch failed: emulators/virtualbox-ose/Makefile:1
error: emulators/virtualbox-ose/Makefile: patch does not apply
% less /tmp/266907c32.diff
% 


Thanks
Comment 37 Vladimir Druzenko freebsd_committer freebsd_triage 2023-04-26 10:20:05 UTC
(In reply to Graham Perrin from comment #36)
PORTREVISION was changed.
Comment 38 Vladimir Druzenko freebsd_committer freebsd_triage 2023-04-26 10:24:23 UTC
BTW, why VBoxGuestAdditions_6.1.*.iso removed from emulators/virtualbox-ose/distinfo?
Comment 39 Graham Perrin freebsd_committer freebsd_triage 2023-04-27 06:43:57 UTC
(In reply to VVD from comment #37)

On 14.0-CURRENT: 


…
/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src/core/settings.c:289:8: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
                char name[ strlen ( name ) + 1 /* NUL */ ];
                     ^
11 warnings and 1 error generated.
kmk: *** [/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/out/freebsd.amd64/release/obj/iPxeBaseBin/src/core/settings.o] Error 1
The failing command:
@clang14 -m32 -c -O2 -fno-pie -fcommon -ffreestanding -ffunction-sections -march=i386 -fomit-frame-pointer -fstrength-reduce -falign-jumps=1 -falign-loops=1 -Os -falign-functions=1 -mstack-alignment=2 -mregparm=3 -mrtd -freg-struct-return -fshort-wchar -Ui386 -Ulinux -include compiler.h -Wall -W -Wformat-nonliteral -fno-stack-protector -fno-dwarf2-cfi-asm -Wno-address -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src/include -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src/arch/x86/include -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src/arch/i386/include -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src/arch/i386/include/pcbios -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/include -I/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/out/freebsd.amd64/release -DVBOX -DVBOX_OSE -DVBOX_WITH_64_BITS_GUESTS -DRT_OS_FREEBSD -D__FREEBSD__ -DRT_ARCH_AMD64 -D__AMD64__ -DVBOX_WITH_DEBUGGER -DVBOX_WITH_HARDENING -DRTPATH_APP_PRIVATE=\"/usr/local/share/virtualbox-ose\" -DRTPATH_APP_PRIVATE_ARCH=\"/usr/local/lib/virtualbox\" -DRTPATH_SHARED_LIBS=\"/usr/local/lib/virtualbox\" -DRTPATH_APP_DOCS=\"/usr/local/share/doc/virtualbox-ose\" -DARCH=i386 -DPLATFORM=pcbios -DVERSION_MAJOR=1 -DVERSION_MINOR=0 -DVERSION_PATCH=0 -DVERSION=\"1.0.0+\" -D_build_id=0xaffeaffe -DOBJECT=settings -Wp,-MD,/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/out/freebsd.amd64/release/obj/iPxeBaseBin/src/core/settings.o.dep -Wp,-MT,/wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/out/freebsd.amd64/release/obj/iPxeBaseBin/src/core/settings.o -Wp,-MP -o /wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/out/freebsd.amd64/release/obj/iPxeBaseBin/src/core/settings.o /wrkdirs/usr/ports/emulators/virtualbox-ose/work/VirtualBox-6.1.44/src/VBox/Devices/PC/ipxe/src/core/settings.c
…


% uname -aKU
FreeBSD mowa219-gjp4-8570p-freebsd 14.0-CURRENT FreeBSD 14.0-CURRENT #38 main-n262032-5e2e3615d91f: Fri Apr  7 18:54:28 BST 2023     grahamperrin@mowa219-gjp4-8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64 1400085 1400085
%
Comment 40 groenveld 2023-04-28 03:01:26 UTC
(In reply to Graham Perrin from comment #39)
-m32 cannot be correct.

John
groenveld@acm.org
Comment 41 Vladimir Druzenko freebsd_committer freebsd_triage 2023-04-28 10:17:25 UTC
(In reply to groenveld from comment #40)
-march=i386 too.
Comment 42 Alex Bylund 2023-04-28 19:22:09 UTC
Another $0.02,

As far as I can tell, USB support is built into 7.0
Comment 43 Graham Perrin freebsd_committer freebsd_triage 2023-04-29 01:50:45 UTC
(In reply to groenveld from comment #34)

> … What happens when you try to build without using Poudriere automation? …

After updating the OS, and without poudriere: success. 

I'll retry poudriere (with the jail equally updated), if problems recur I should probably treat them as off-topic from this bug report.
Comment 44 Graham Perrin freebsd_committer freebsd_triage 2023-04-29 09:48:08 UTC
Created attachment 241846 [details]
emulators/virtualbox-ose-6.1.44 2023-04-29 09:48

John's comment #32 patch (includes a workaround/fix for bug 270189), updated to apply to an updated copy of the ports tree.
Comment 45 Graham Perrin freebsd_committer freebsd_triage 2023-04-29 23:55:13 UTC
Created attachment 241866 [details]
emulators/virtualbox-ose-6.1.44 2023-04-30 00:49

I don't know what I did wrong with the patch at comment 44, but bug 270189 comment 17 noted that the patch failed. 

This should be better.
Comment 46 Graham Perrin freebsd_committer freebsd_triage 2023-04-30 00:57:47 UTC
Versions prior to 6.1.44 and prior to 7.0.8 have security vulnerabilities.
Comment 47 rkoberman 2023-04-30 01:38:55 UTC
(In reply to Graham Perrin from comment #45)
I confirm that this one patched cleanly. Now to get it committed!

Thanks!
Comment 48 Jochen Neumeister freebsd_committer freebsd_triage 2023-04-30 07:53:12 UTC
We have a lot of patches here. Which ones are the latest?

Jochen with has ports-secteam
Comment 49 Graham Perrin freebsd_committer freebsd_triage 2023-04-30 10:54:47 UTC
(In reply to Jochen Neumeister from comment #48)

> We have a lot of patches here. 

Apologies for the vagueness. 

Now obsolete: two patches that preceded Oracle's release of 6.1.44.


> Which ones are the latest? …

There remains just one non-obsolete patch, which is currently flagged for maintainer approval: 

     emulators/virtualbox-ose-6.1.44 2023-04-30 00:49

----

At <https://bugs.freebsd.org/bugzilla/attachment.cgi?id=241866&action=diff#b/emulators/virtualbox-ose/Makefile_sec2>, the six additional lines are to work around show-stopping bug 270189 on FreeBSD 14.0-CURRENT. Credit to John D Groenveld for his work at comment 32. 

Line 117: 

.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400079


Looking ahead: this area of the Makefile might be further enhanced to accommodate a workaround (or fix) for stable/13 bug 270189 use cases. 


For now: given the security aspect, I suggest not waiting until those use cases are fixed; the essence of 
    emulators/virtualbox-ose-6.1.44 2023-04-30 00:49 
is an update to 6.1.44, for which there are no known vulnerabilities. 

HTH
Comment 50 Graham Perrin freebsd_committer freebsd_triage 2023-04-30 13:44:16 UTC
(In reply to Cy Schubert from comment #25)

> Does someone have a patch for 7.0.8?

Not yet, I'll make a cross-reference from a related bug report.
Comment 51 Graham Perrin freebsd_committer freebsd_triage 2023-05-02 18:53:25 UTC
Comment on attachment 241866 [details]
emulators/virtualbox-ose-6.1.44 2023-04-30 00:49

With this patch, emulators/virtualbox-ose does not build in poudriere on 14.0-CURRENT. Let's obsolete it. 

The patch at bug 270189 comment 34 includes: 

* enough for build to succeed in poudriere

* patches to settings.c and httpcore.c, work on which is incomplete.
Comment 52 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-09 17:32:49 UTC
(In reply to Graham Perrin from comment #51)
Do 6.1.36 build without errors on 14?
Comment 53 Graham Perrin freebsd_committer freebsd_triage 2023-05-09 18:08:34 UTC
(In reply to Vladimir Druzenko from comment #52)

Yes, however virtualbox-ose is unusable; see bug 270189.
Comment 54 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-09 18:16:20 UTC
(In reply to Graham Perrin from comment #53)
Thanks.
But both 6.1.36 and 6.1.44 build and work fine on 13?
If so - why not commit it with BROKEN on 14 for now?
Comment 55 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-09 19:50:09 UTC
Updated 1 host 1 hour ago from 13.1 to 13.2 and VirtualBox from 6.1.36 to 6.1.44.
Run 13 VMs without issues.
I'll post here if I run into any problems.
Comment 56 Graham Perrin freebsd_committer freebsd_triage 2023-05-10 05:51:37 UTC
(In reply to Vladimir Druzenko from comment #55)

Thanks for testing. 

Since all patches in 266907 are obsolete, can you clarify how things are patched in your case?

(I can guess the answer, but let's make it clear for whoever will commit.)
Comment 57 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-10 21:20:36 UTC
Created attachment 242115 [details]
update to 6.1.44 (for 12.x and 13.x)

(In reply to Graham Perrin from comment #56)
Patch attached.

Work fine for more than 26 hours.
Comment 58 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-13 12:05:39 UTC
Updated 3 more hosts: 2 hosts 2 days ago and 1 host yesterday.
25 VMs total on 3 hosts.

Now it's 4 hosts with total of 38 VMs run.

All work fine.
13.2 amd64, 6.1.44.
Comment 59 Jochen Neumeister freebsd_committer freebsd_triage 2023-05-13 19:27:49 UTC
(In reply to Vladimir Druzenko from comment #58)

Hello Vladimir,

thank you for your work. You have the ok from ports-secteam for the commit, since it is a security update (remember the vuxml entry please?).

Greetings
Jochen
Comment 60 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-13 21:36:18 UTC
(In reply to Jochen Neumeister from comment #59)
I can't commit without review (I'm not in vbox group and need approve from mentors): https://reviews.freebsd.org/D40088
And I don't know how to correct create vuxml.
Comment 61 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-14 00:26:53 UTC
BTW, emulators/virtualbox-ose/Makefile have lines:
# llvm10 in FreeBSD before r364284 miscompiles virtualbox 6.1 causing errors.
# force llvm11 from ports
.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1300109
BUILD_DEPENDS+= clang${VBOX_LLVM_VER}:devel/llvm${VBOX_LLVM_VER}
CC=             clang${VBOX_LLVM_VER}
CXX=            clang++${VBOX_LLVM_VER}
VBOX_LLVM_VER?= 11
.endif

Is it correct to replace lines above with this one:
USES+=           llvm:min=11,build
?

Or it need 2 more:
CC=             clang${LLVM_VERSION}
CXX=            clang++${LLVM_VERSION}
?
Comment 62 commit-hook freebsd_committer freebsd_triage 2023-05-15 18:01:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1d37fcd8316a078e512852b7c565b5b2cf2dcbcd

commit 1d37fcd8316a078e512852b7c565b5b2cf2dcbcd
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2023-05-15 17:46:34 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2023-05-15 17:46:34 +0000

    emulators/virtualbox-ose{-*}: Update to 6.1.44

    Changes:                https://www.virtualbox.org/wiki/Changelog-6.1#v44
    Author:                 lwhsu@FreeBSD.org
    Note:                   BROKEN on 14

    PR:                     266907
    Reported by:            Ian Dickens <ian@south-border.com>
    Approved by:            arrowd (mentor), joneum (ports-secteam)
    Differential Revision:  https://reviews.freebsd.org/D40088

 emulators/virtualbox-ose-additions/Makefile |  4 ++--
 emulators/virtualbox-ose-additions/distinfo |  6 +++---
 emulators/virtualbox-ose-kmod/Makefile      |  3 +--
 emulators/virtualbox-ose-kmod/distinfo      |  6 +++---
 emulators/virtualbox-ose/Makefile           |  3 +--
 emulators/virtualbox-ose/distinfo           | 10 +++++-----
 emulators/virtualbox-ose/pkg-plist          |  2 ++
 7 files changed, 17 insertions(+), 17 deletions(-)
Comment 63 commit-hook freebsd_committer freebsd_triage 2023-05-15 18:57:16 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=962c7765fd6f44fc7af427e4cebb86c204a0e691

commit 962c7765fd6f44fc7af427e4cebb86c204a0e691
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2023-05-15 17:46:34 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2023-05-15 18:56:50 +0000

    emulators/virtualbox-ose{-*}: Update to 6.1.44

    Changes:                https://www.virtualbox.org/wiki/Changelog-6.1#v44
    Author:                 lwhsu@FreeBSD.org
    Note:                   BROKEN on 14

    PR:                     266907
    Reported by:            Ian Dickens <ian@south-border.com>
    Approved by:            arrowd (mentor), joneum (ports-secteam)
    Differential Revision:  https://reviews.freebsd.org/D40088

    (cherry picked from commit 1d37fcd8316a078e512852b7c565b5b2cf2dcbcd)

 emulators/virtualbox-ose-additions/Makefile |  4 ++--
 emulators/virtualbox-ose-additions/distinfo |  6 +++---
 emulators/virtualbox-ose-kmod/Makefile      |  2 +-
 emulators/virtualbox-ose-kmod/distinfo      |  6 +++---
 emulators/virtualbox-ose/Makefile           |  3 +--
 emulators/virtualbox-ose/distinfo           | 10 +++++-----
 emulators/virtualbox-ose/pkg-plist          |  2 ++
 7 files changed, 17 insertions(+), 16 deletions(-)
Comment 64 Alex Bylund 2023-05-16 14:03:44 UTC
(In reply to Vladimir Druzenko from comment #61)

Also, there is a BROKEN flag in the ports.

BROKEN_FreeBSD_14=      error: not completely sure
Comment 65 Cy Schubert freebsd_committer freebsd_triage 2023-05-16 14:08:17 UTC
(In reply to Alex Bylund from comment #64)
BROKEN flag is for when it won't build. It builds ok.

IGNROE flag is for when it builds ok but won't run. IT needs the IGNORE flag.
Comment 66 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-16 14:50:52 UTC
(In reply to Cy Schubert from comment #65)

IGNORE_FreeBSD_14= Not supported on FreeBSD 14: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189
?

For all 3 ports?
Comment 67 Cy Schubert freebsd_committer freebsd_triage 2023-05-16 15:02:54 UTC
(In reply to Vladimir Druzenko from comment #66)

Not supported is not really true or is it? If it is not supported under FreeBSD-14 we must deperecate the port and expire it when FreeBSD 13 becomes EOL. If the intention is to fix it under FreeBSD-14 then the error should read:

IGNORE_FreeBSD_14=Failed to construct device 'VMMDev'
Comment 68 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-16 15:18:53 UTC
(In reply to Cy Schubert from comment #67)
It just doesn't work now (AFAIU): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270189

> IGNORE_FreeBSD_14=Failed to construct device 'VMMDev'
Exact this line or is it an example?

For all 3 ports?

If somebody know how to do this correct please write.
Comment 69 Graham Perrin freebsd_committer freebsd_triage 2023-05-16 16:09:36 UTC
I suggest continuing the 14.0 discussion under bug 270189: 

> emulators/virtualbox-ose: guest machines are no longer usable: 
> Failed to construct device 'VMMDev' instance #0 (VERR_INTERNAL_ERROR_3).

14.0-CURRENT is specified there in bug 270189 comment 0.
Comment 70 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-16 16:22:12 UTC
(In reply to Graham Perrin from comment #69)
Ok.

Thanks for patches and testing.