Bug 266988 - sysutils/pefs-kmod: Update to bug cache behaviour on ZFS (and others)
Summary: sysutils/pefs-kmod: Update to bug cache behaviour on ZFS (and others)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/freebsd-pefs/pefs/...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-12 10:24 UTC by Daniel O'Connor
Modified: 2022-10-14 05:53 UTC (History)
1 user (show)

See Also:
fernape: merge-quarterly+

Attachments
Patch to update the port (1.13 KB, patch)
2022-10-12 10:24 UTC, Daniel O'Connor 		darius: maintainer-approval+
Details | Diff
Updated diff to restore PORTEPOCH (1.12 KB, patch)
2022-10-12 22:58 UTC, Daniel O'Connor 		darius: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel O'Connor 2022-10-12 10:24:12 UTC 
Created attachment 237233 [details]
Patch to update the port

Note that I am not sure about the PORTEPOCH - ie do I need to keep it and 1 (or bump it?) if someone is upgrading from a significantly older version..
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-12 12:04:06 UTC 
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

PORTEPOCH should never be removed, and it should only be bumped again if at some point versions go downwards.

Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-12 12:07:46 UTC 
Do you think this is something worth to have in 2022Q4?
Comment 3 Daniel O'Connor 2022-10-12 22:27:40 UTC 
Yes if possible, otherwise the port is broken when run on ZFS.
Comment 4 Daniel O'Connor 2022-10-12 22:58:05 UTC 
Created attachment 237249 [details]
Updated diff to restore PORTEPOCH
Comment 5 Daniel O'Connor 2022-10-12 22:58:49 UTC 
The only change is aa7f151 - I have put that in the URL field.
I have updated the diff to restore PORTEPOCH.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-14 05:52:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0fda52c2839138c8765c017228b4a086baf3a404

commit 0fda52c2839138c8765c017228b4a086baf3a404
Author:     Daniel O'Connor <darius@dons.net.au>
AuthorDate: 2022-10-12 12:03:07 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-14 05:48:07 +0000

    sysutils/pefs-kmod: update to g20221012

    Update to bug cache behavior on ZFS (and others)

    PR:             266988
    Reported by:    darius@dons.net.au (maintainer)
    MFH:            2022Q4 (bugfix)

 sysutils/pefs-kmod/Makefile | 4 ++--
 sysutils/pefs-kmod/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-14 05:52:56 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ffd2b3c831ece28fd2b96a9c72c2324ecad5970

commit 9ffd2b3c831ece28fd2b96a9c72c2324ecad5970
Author:     Daniel O'Connor <darius@dons.net.au>
AuthorDate: 2022-10-12 12:03:07 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-14 05:49:11 +0000

    sysutils/pefs-kmod: update to g20221012

    Update to bug cache behavior on ZFS (and others)

    PR:             266988
    Reported by:    darius@dons.net.au (maintainer)
    MFH:            2022Q4 (bugfix)

    (cherry picked from commit 0fda52c2839138c8765c017228b4a086baf3a404)

 sysutils/pefs-kmod/Makefile | 4 ++--
 sysutils/pefs-kmod/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-14 05:53:45 UTC 
Committed and merged to 2022Q4,

Thanks