Providing documentation is fairly standard. So is (or should be) looking for it in the right place, in this case (per plist) %%DOCSDIR%%/UserManual.pdf. Combined, these lead to "Failed to open file:///home/pauamma/.config/VirtualBox/UserManual.pdf. Make sure your desktop environment can properly handle URLs of this type." from Help > Contents and a failure to find the manual in the expected location. Ideally, fix both for seamless manual viewing. Note: this may also affect emulators/virtualbox-ose-legacy.
Re: bug 266778 comment 0, but without attempting to apply the patch as intended: After installing a build of emulators/virtualbox-ose with MANUAL=on, I manually edited line 16 of the installed /usr/local/bin/virtualbox PATH="/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/local/sbin" Now, all Help menu options work. Neat! So, I guess: * bug 266778 for a patch to fix the Help menu * this bug 266992 for an easy patch to add MANUAL to the OPTIONS_DEFAULT line of the Makefile <https://cgit.freebsd.org/ports/tree/emulators/virtualbox-ose/Makefile> <https://cgit.freebsd.org/ports/tree/emulators/virtualbox-ose-legacy/Makefile>
Created attachment 242217 [details] Add /usr/local/bin:/usr/local/sbin to PATH (In reply to Graham Perrin from comment #1) Check patch.
(In reply to Vladimir Druzenko from comment #2) Oh. Other PR for this change and it already have same patch.
Created attachment 242219 [details] make option MANUAL on by default
Created attachment 242220 [details] make option MANUAL on by default Fix typo.
https://reviews.freebsd.org/D40118
MANUAL option require very big port print/texlive-texmf for build. Is it good idea to turn it on by default?
(In reply to Vladimir Druzenko from comment #7) I'm confused. Is the pkg-plist line > %%MANUAL%%%%DOCSDIR%%/UserManual.pdf for the same manual that's (currently) present in ~/.config/VirtualBox/UserManual.pdf and which (must have changed at some point meanwhile) now opens seamlessly from Help > Contents?
(In reply to Pau Amma from comment #8) Never mind. I just noticed ~/.config/VirtualBox/UserManual.pdf is a holdover from VirtualBox 5.x. So now I'm no longer sure how to best fix the inconsistency, but IMO looking for the manual in the wrong place (where it used to be) and finding an obsolete one violates POLA. I'd much rather have it look in the right place (%%DOCSDIR%%) and not find it if not installed. (I'd also like to have a flavor with the current manual installed so I can use pkg, but that may be a different bug if the current MANUAL off remains.) What do you think?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a0ef5898beb4c6a73e9d94aaa452c0eb37cbb14c commit a0ef5898beb4c6a73e9d94aaa452c0eb37cbb14c Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2023-05-19 15:50:33 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2023-05-19 15:50:33 +0000 emulators/virtualbox-ose[-legacy]: rename option MANUAL to DOCS and make it enabled by default PR: 266992 Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D40118 emulators/virtualbox-ose-legacy/Makefile | 13 ++++++------- emulators/virtualbox-ose-legacy/pkg-plist | 2 +- emulators/virtualbox-ose/Makefile | 12 ++++++------ emulators/virtualbox-ose/pkg-plist | 2 +- 4 files changed, 14 insertions(+), 15 deletions(-)
(In reply to Pau Amma from comment #9) Check /usr/local/share/doc/virtualbox-ose.