Bug 267030 - ports-mgmt/pkg_replace: Warned about PKG_SUFX on every fetch / build
Summary: ports-mgmt/pkg_replace: Warned about PKG_SUFX on every fetch / build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-10-13 23:29 UTC by Tomoaki AOKI
Modified: 2022-10-16 17:36 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kdeguchi)

Attachments
Update to pkg_replace-20221012 (955 bytes, patch)
2022-10-14 03:28 UTC, Ken DEGUCHI 		kdeguchi: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoaki AOKI 2022-10-13 23:29:29 UTC 
ports-mgmt/pkg_replace is warned about PKG_SUFX usage on every fetch / build as below.

/!\ WARNING /!\

PKG_SUFX is defined, it should be replaced with PKG_COMPRESSION_FORMAT


This seems to be emitted by Mk/bsd.port.mk at line 2192.

% grep -r -n "PKG_SUFX" /usr/ports/Mk/
/usr/ports/Mk/bsd.port.mk:2184:PKG_SUFX?=       .tar
/usr/ports/Mk/bsd.port.mk:2186:PKG_SUFX?=       .txz
/usr/ports/Mk/bsd.port.mk:2188:PKG_COMPRESSION_FORMAT?= ${PKG_SUFX:S/.//}
/usr/ports/Mk/bsd.port.mk:2190:.      if defined(PKG_SUFX)
/usr/ports/Mk/bsd.port.mk:2191:PKG_COMPRESSION_FORMAT?= ${PKG_SUFX:S/.//}
/usr/ports/Mk/bsd.port.mk:2192:WARNING+= "PKG_SUFX is defined, it should be replaced with PKG_COMPRESSION_FORMAT"
/usr/ports/Mk/bsd.port.mk:2194:PKG_SUFX=        .pkg
/usr/ports/Mk/bsd.port.mk:2594:PKGFILE?=                ${PKGREPOSITORY}/${PKGNAME}${PKG_SUFX}
/usr/ports/Mk/bsd.port.mk:2596:PKGFILE?=                ${.CURDIR}/${PKGNAME}${PKG_SUFX}
/usr/ports/Mk/bsd.port.mk:2598:WRKDIR_PKGFILE=  ${WRKDIR}/pkg/${PKGNAME}${PKG_SUFX}
/usr/ports/Mk/bsd.port.mk:2603:PKGLATESTFILE=           ${PKGLATESTREPOSITORY}/${PKGBASE}${PKG_SUFX}
/usr/ports/Mk/bsd.port.mk:3446: @if [ -f "${WRKDIR}/pkg/${PKGNAME}${PKG_SUFX}" ]; then \
Comment 1 Ken DEGUCHI 2022-10-14 03:28:34 UTC 
Created attachment 237281 [details]
Update to pkg_replace-20221012

Fix PKG_SUFX warning message
Comment 2 Tomoaki AOKI 2022-10-14 10:58:30 UTC 
(In reply to kdeguchi from comment #1)

Confirmed fixed with this patch. Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-16 17:35:50 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-16 17:36:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1721ff69ec28ef7272ecc54f4282bbfbb84b0dac

commit 1721ff69ec28ef7272ecc54f4282bbfbb84b0dac
Author:     Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
AuthorDate: 2022-10-14 05:35:16 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-16 17:31:54 +0000

    ports-mgmt/pkg_replace: update to 20222012

    Fix warn about PKG_SUFX on every fetch / build

    PR:             267030
    Reported by:    junchoon@dec.sakura.ne.jp
    Approved by:    kdeguchi@sz.tokoha-u.ac.jp (maintainer)

 ports-mgmt/pkg_replace/Makefile | 2 +-
 ports-mgmt/pkg_replace/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)