Bug 267038 - devel/robin-hood-hashing: enable CMake support via vendor install
Summary: devel/robin-hood-hashing: enable CMake support via vendor install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-10-14 07:45 UTC by Jan Beich
Modified: 2022-10-28 11:33 UTC (History)
0 users

See Also:


Attachments
v1 (apply via "git am") (1.93 KB, patch)
2022-10-14 07:45 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-10-14 07:45:37 UTC
Created attachment 237288 [details]
v1 (apply via "git am")

Required to unbundle robin-hood-hashing in graphics/vulkan-validation-layers, see https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/v1.3.230/CMakeLists.txt#L242

Looking at https://repology.org/project/robin-hood-hashing/versions it seems CRUX, Gentoo, Solus, Vcpkg, Void pass -DRH_STANDALONE_PROJECT=OFF in order to avoid building tests.

$ echo 'find_package(robin_hood REQUIRED)' >CMakeLists.txt
$ cmake -Wno-dev .
[...]
CMake Error at CMakeLists.txt:1 (find_package):
  By not providing "Findrobin_hood.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "robin_hood", but CMake did not find one.

  Could not find a package configuration file provided by "robin_hood" with
  any of the following names:

    robin_hoodConfig.cmake
    robin_hood-config.cmake

  Add the installation prefix of "robin_hood" to CMAKE_PREFIX_PATH or set
  "robin_hood_DIR" to a directory containing one of the above files.  If
  "robin_hood" provides a separate development package or SDK, be sure it has
  been installed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-10-28 11:32:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f465f8506f78c7d5a5f391dfb5f3fabb10adbf40

commit f465f8506f78c7d5a5f391dfb5f3fabb10adbf40
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-10-14 07:25:07 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-10-28 11:31:20 +0000

    devel/robin-hood-hashing: enable CMake support

    CMake Error at CMakeLists.txt:1 (find_package):
      By not providing "Findrobin_hood.cmake" in CMAKE_MODULE_PATH this project
      has asked CMake to find a package configuration file provided by
      "robin_hood", but CMake did not find one.

      Could not find a package configuration file provided by "robin_hood" with
      any of the following names:

        robin_hoodConfig.cmake
        robin_hood-config.cmake

      Add the installation prefix of "robin_hood" to CMAKE_PREFIX_PATH or set
      "robin_hood_DIR" to a directory containing one of the above files.  If
      "robin_hood" provides a separate development package or SDK, be sure it has
      been installed.

    PR:             267038
    Inspired by:    CRUX, Gentoo, Solus, Vcpkg, Void
    Approved by:    maintainer timeout (2 weeks)

 devel/robin-hood-hashing/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-28 11:32:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=84137f3accde140d4853b17347a057278732f0ac

commit 84137f3accde140d4853b17347a057278732f0ac
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-10-14 07:46:51 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-10-28 11:31:31 +0000

    graphics/vulkan-validation-layers: unbundle robin-hood-hashing after f465f8506f78

    PR:             267038

 graphics/vulkan-validation-layers/Makefile         |  9 +++----
 graphics/vulkan-validation-layers/distinfo         |  2 --
 .../files/patch-CMakeLists.txt                     | 30 ++--------------------
 3 files changed, 6 insertions(+), 35 deletions(-)