Bug 267059 - multimedia/mpv: enable LUAJIT by default
Summary: multimedia/mpv: enable LUAJIT by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-10-14 19:08 UTC by Jan Beich
Modified: 2022-11-12 20:57 UTC (History)
0 users

See Also:

Attachments
v1 (apply via "git am") (1.09 KB, patch)
2022-10-14 19:08 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-10-14 19:08:07 UTC 
Created attachment 237307 [details]
v1 (apply via "git am")

mpv uses Lua for OSC, stats, ytdl, etc. where LuaJIT may improve performance (not benchmarked). Upstream doesn't support modern Lua dialects, so if mpv is going to use a separate lua* package may as well use something more actively developed/maintained.

Tested by myself for years via lang/luajit and lang/luajit-openresty. However, I don't use user scripts (i.e., ~/.mpv/scripts/ is empty).

See also https://github.com/archlinux/svntogit-community/commit/f1ac411770c5
         https://github.com/mpv-player/mpv/wiki/FAQ#Why_does_mpv_not_support_Lua_53_or_newer
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-11-12 20:40:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c1bd181bbebaf3f662498e666afe501e8f7bd715

commit c1bd181bbebaf3f662498e666afe501e8f7bd715
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-10-14 18:50:06 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-11-12 20:36:41 +0000

    multimedia/mpv: enable LUAJIT by default

    PR:             267059
    Inspired by:    Arch

 multimedia/mpv/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2022-11-12 20:57:51 UTC 
Also "Inspired by: Alpine" per https://gitlab.alpinelinux.org/alpine/aports/-/commit/16f91c64b0c8