Bug 267066 - textproc/py-python-lsp-server: whatthepatch dependency is missing
Summary: textproc/py-python-lsp-server: whatthepatch dependency is missing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-15 06:57 UTC by Yuri Victorovich
Modified: 2022-10-15 07:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rhurlin)


Attachments
patch to add missing dependency (1.13 KB, patch)
2022-10-15 07:18 UTC, Rainer Hurling
rhurlin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2022-10-15 06:57:48 UTC
> pkg_resources.DistributionNotFound: The 'whatthepatch' distribution was not found and is required by python-lsp-server


pyproject.toml contains whatthepatch as a required dependency but the port's Makefile only has it in TEST_DEPENDS.
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2022-10-15 07:18:05 UTC
Created attachment 237318 [details]
patch to add missing dependency

Add missing run dependency textproc/py-whatthepatch as wanted by pyproject.toml
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-15 07:24:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=309c70a92b7ef846ea361c53fe290a37c91893d5

commit 309c70a92b7ef846ea361c53fe290a37c91893d5
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2022-10-15 07:20:16 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2022-10-15 07:22:56 +0000

    textproc/py-python-lsp-server: Add missing dep

    Add missing run dependency textproc/py-whatthepatch as wanted by
    pyproject.toml.

    PR:             267066
    MFH:            2022Q4

 textproc/py-python-lsp-server/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-15 07:25:29 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90089ea6aab07f7687607ed0413be5d74833df8a

commit 90089ea6aab07f7687607ed0413be5d74833df8a
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2022-10-15 07:20:16 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2022-10-15 07:24:30 +0000

    textproc/py-python-lsp-server: Add missing dep

    Add missing run dependency textproc/py-whatthepatch as wanted by
    pyproject.toml.

    PR:             267066
    MFH:            2022Q4
    (cherry picked from commit 309c70a92b7ef846ea361c53fe290a37c91893d5)

 textproc/py-python-lsp-server/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2022-10-15 07:26:32 UTC
Committed. Thanks for the hint :)