Bug 267101 - sysutils/upower: Use USE_GITLAB
Summary: sysutils/upower: Use USE_GITLAB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-15 18:55 UTC by Daniel Engberg
Modified: 2022-10-22 20:13 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
Patch for upower (1.47 KB, patch)
2022-10-15 18:55 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-10-15 18:55:41 UTC
Created attachment 237353 [details]
Patch for upower

Use USE_GITLAB to follow Porters Handbook more closely and be consistent with ports tree

Compile tested on FreeBSD 13.1-STABLE (amd64)
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-10-22 10:39:34 UTC
Moin moin 

I'm not quite sure this is that important -- it requires people to refetch the distfile for nothing to gain (from a user standpoint).

The idea is good to make the port match the porters handbook, but I think it would be probably better done in a port-update, or a framework wide change.

However, I don't feel strong about it :-) -- So if you can verify that the distfile has identical content, feel free to ship it.


mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-22 20:10:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b99230430c78af4f104556e2f0f6e2f5136977ba

commit b99230430c78af4f104556e2f0f6e2f5136977ba
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-10-22 20:04:13 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-10-22 20:10:30 +0000

    sysutils/upower: Use USE_GITLAB

    Use USE_GITLAB to follow Porters Handbook more closely and be
    consistent with ports tree

    PR:             267101
    Approved by:    desktop (tcberner)

 sysutils/upower/Makefile | 10 +++++-----
 sysutils/upower/distinfo |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)