Bug 267115 - multimedia/minitube: fails to build with mpv 0.35
Summary: multimedia/minitube: fails to build with mpv 0.35
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/flaviotordini/mini...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2022-10-16 06:05 UTC by Jan Beich
Modified: 2022-11-14 09:17 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
poudriere error log (100.44 KB, text/plain)
2022-10-16 06:05 UTC, Jan Beich 		no flags Details
Support mpv 0.35 (1.68 KB, patch)
2022-11-13 07:58 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-10-16 06:05:19 UTC 
Created attachment 237370 [details]
poudriere error log

Regressed by http://github.com/mpv-player/mpv/commit/632059816add. Can you provide a fix or ask upstream? Otherwise, this port will be marked BROKEN or switched to mpv034 (port fork).

lib/media/src/mpv/mpvwidget.cpp:33:67: error: excess elements in struct initializer
    mpv_opengl_init_params gl_init_params{get_proc_address, this, nullptr};
                                                                  ^~~~~~~
Comment 1 Brad Smith 2022-11-13 07:08:08 UTC 
There is a patch in this bug report that allows minitube to build with the API with mpv 0.35.0.. https://github.com/flaviotordini/minitube/issues/217.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-11-13 07:58:47 UTC 
Created attachment 238048 [details]
Support mpv 0.35

Tested on 13.1-p3 amd64: check-plist, build, run.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-11-13 23:12:14 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-11-13 23:12:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac9b20c88deb90ca6604c7a07f4e36f826bffd6c

commit ac9b20c88deb90ca6604c7a07f4e36f826bffd6c
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2022-11-13 21:05:53 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-11-13 23:12:27 +0000

    multimedia/minitube: Fix build with mpv-0.35

    PR:             267115

 multimedia/minitube/Makefile                           |  4 ++--
 .../files/patch-lib_media_src_mpv_mpvwidget.cpp (new)  | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2022-11-14 08:34:59 UTC 
Maybe remove multimedia/mpv034?
Comment 6 Jan Beich freebsd_committer freebsd_triage 2022-11-14 09:17:02 UTC 
(In reply to VVD from comment #5)
After bug 267114 is fixed. Alternatively, ports bb92bf58eb2d can help it self-destruct over time.