Bug 267131 - devel/schilybase: update to 2022-10-16
Summary: devel/schilybase: update to 2022-10-16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: http://fuz.su/pub/schilytools/AN-2022...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-10-16 19:15 UTC by Robert Clausecker
Modified: 2022-10-18 05:07 UTC (History)
2 users (show)

See Also:


Attachments
devel/schilybase: update to 2022-10-16 (28.04 KB, patch)
2022-10-16 19:15 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff
0001-New-Port-archivers-tartest-Test-tar-archive-for-POSI.patch (14.49 KB, patch)
2022-10-17 12:02 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff
0002-devel-schilybase-update-to-2022-10-16.patch (14.17 KB, patch)
2022-10-17 12:03 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-10-16 19:15:40 UTC
Created attachment 237381 [details]
devel/schilybase: update to 2022-10-16

- do not install etc/termcap.  It is identical to /etc/termcap.
 - fix pbosh(1), jbosh(1), and obosh(1).  Make renamed man pages work by
   fixing the .so directives to point to the new names of the targets.
 - add new master site
 - split tartest and star test suite into new port archivers/tartest
 - remove DEPRECATED option of misc/schilytools as man2html is gone
   for good now

Tested with Poudriere on armv7 arm64 i386 amd64 riscv64 FreeBSD 13.1.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-17 06:00:02 UTC
Hummm... this patch seems to touch quite a few other ports with unrelated changes...

Would you mind checking it?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-10-17 08:13:07 UTC
(In reply to Fernando Apesteguía from comment #1)

Hi Fernando,

Schilytools is a collection of ports all built from the same distribution file.  Therefore, I always submit updates for all of them at once.  The master port is devel/schilybase.  misc/schilytools is a meta port depending on all individual components.

Please let me know if there are any unrelated changes I accidentally included.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-17 08:23:55 UTC
(In reply to Robert Clausecker from comment #2)
OK. The thing is that this patch does so many things, including adding a new port (archivers/tartest). I suppose it is needed for the update of archivers/star and others and that we can not do it in a separate patch?
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2022-10-17 09:18:06 UTC
(In reply to Fernando Apesteguía from comment #3)

Hi Fernando,

If it makes it easier for you, I can upload it to Phabricator for you to review.
Archivers/tartest was split off as its contents used to be a non-default option to archivers/star.  Having it as a separate port makes it easier for binary package users to install this software.

I prefer not to have multiple individual patches as the testing required is significant (running the test suite for each port in the set on each architecture).
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-17 11:07:20 UTC
(In reply to Robert Clausecker from comment #4)
The thing is that adding a new port in the middle of a bigger change is pretty obscure. Would it be possible to update schilybase without splitting of archivers/tartest and then send a follow-up patch that adds the new port?
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2022-10-17 11:53:03 UTC
(In reply to Fernando Apesteguía from comment #5)

I've done the same before (see PR #266475), but if it makes the port easier for you to review, I can try to split the change up into two parts.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2022-10-17 12:02:02 UTC
Created attachment 237398 [details]
0001-New-Port-archivers-tartest-Test-tar-archive-for-POSI.patch

Patch 1: split archivers/tartest off archivers/star and make misc/schilytools depend on the new port.
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2022-10-17 12:03:27 UTC
Created attachment 237399 [details]
0002-devel-schilybase-update-to-2022-10-16.patch

Patch 2: update schilytools to 2022-10-16

The two patches together have the same contents as attachment #236651 [details].
I did not individually test them again.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-18 05:07:09 UTC
Committed,

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-10-18 05:07:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=98e169c3d94fadcba5838d18f32b65d884a0750d

commit 98e169c3d94fadcba5838d18f32b65d884a0750d
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-10-17 17:45:49 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-18 05:02:38 +0000

    devel/schilybase: update to 2022-10-16

    ChangeLog: http://fuz.su/pub/schilytools/AN-2022-10-16.txt

    This commit creates a new port archivers/tartest splitted off from
    archivers/star. misc/schilytools depends now on this new port.

    PR:             267131
    Reported by:    fuz@fuz.su (maintainer)

 UPDATING                                           |   7 ++
 archivers/Makefile                                 |   1 +
 archivers/star/Makefile                            |   8 +-
 archivers/star/pkg-plist                           |  58 -----------
 archivers/tartest/Makefile (new)                   |  14 +++
 archivers/tartest/pkg-descr (new)                  |  11 +++
 archivers/tartest/pkg-plist (new)                  | 109 +++++++++++++++++++++
 devel/schilybase/Makefile                          |   6 +-
 devel/schilybase/Makefile.master                   |   6 +-
 devel/schilybase/distinfo                          |   6 +-
 .../patch-RULES_i386-freebsd-clang.rul (gone)      |  24 -----
 .../files/patch-RULES_i386-freebsd-gcc.rul (gone)  |  24 -----
 devel/schilybase/files/patch-btcflash_btcflash.1   |   2 +-
 devel/schilybase/files/patch-cdrecord_cdrecord.1   |   8 +-
 .../files/patch-mkisofs_mkisofs.8 (gone)           |  20 ----
 devel/schilybase/files/patch-obosh_obosh.1 (new)   |  90 +++++++++++++++++
 devel/schilybase/files/patch-pbosh_pbosh.1 (new)   |   6 ++
 devel/schilybase/files/patch-readcd_readcd.1       |   4 +-
 devel/schilybase/files/patch-scgcheck_scgcheck.1   |  10 +-
 devel/schilybase/files/patch-sh_jsh.1 (new)        |   6 ++
 devel/schilybase/files/patch-sh_sh.1               |  27 ++++-
 devel/schilybase/pkg-plist                         |   1 -
 misc/schilytools/Makefile                          |   7 +-
 sysutils/schilyutils/Makefile                      |   2 +-
 24 files changed, 298 insertions(+), 159 deletions(-)