Bug 267149 - net/openldap24-{server,client}: deprecate, expire and remove port
Summary: net/openldap24-{server,client}: deprecate, expire and remove port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-17 11:32 UTC by Michael Osipov
Modified: 2022-10-23 18:55 UTC (History)
2 users (show)

See Also:
delphij: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2022-10-17 11:32:07 UTC
OpenLDAP 2.4 is not supported by upstream anymore:

* https://lists.openldap.org/hyperkitty/list/openldap-announce@openldap.org/thread/2QQNVWPUUG54JM7FGQHMMF3H4KS2PPKQ/
* https://github.com/openldap/openldap.github.io/issues/2#issuecomment-1003778077
* Front page doesn't list it also: https://openldap.org/software/download/

Since the DEFAULT_VERSION has already been changed, mark the port as deprecated, add an expiry date (maybe end of year, next quarterly won't have it anymore) and remove it.
Comment 1 Xin LI freebsd_committer freebsd_triage 2022-10-21 05:08:20 UTC
Yes this is reasonable.  I'll do it tomorrow.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-21 16:44:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb3af46227299bbf20930ee853769bfacb734d66

commit fb3af46227299bbf20930ee853769bfacb734d66
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2022-10-21 16:39:59 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2022-10-21 16:39:59 +0000

    net/openldap24-server: Deprecate and set expiration date to 2022-12-31

    Upstream is no longer supporting OpenLDAP 2.4 series; existing users
    should migrate to a newer OpenLDAP release.

    Reference: https://github.com/openldap/openldap.github.io/issues/2#issuecomment-1003778077
    Reported by:    Michael Osipov
    PR:             267149

 net/openldap24-server/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-21 17:26:59 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b62b5badf268344a746ffb6e29cfeae7a73c5bbc

commit b62b5badf268344a746ffb6e29cfeae7a73c5bbc
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2022-10-21 16:39:59 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2022-10-21 17:25:58 +0000

    net/openldap24-server: Deprecate and set expiration date to 2022-12-31

    Upstream is no longer supporting OpenLDAP 2.4 series; existing users
    should migrate to a newer OpenLDAP release.

    Reference: https://github.com/openldap/openldap.github.io/issues/2#issuecomment-1003778077
    Reported by:    Michael Osipov
    PR:             267149

    (cherry picked from commit fb3af46227299bbf20930ee853769bfacb734d66)

 net/openldap24-server/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 4 Michael Osipov 2022-10-23 18:55:31 UTC
Thank you, please don't forget to update these no later than end of year:
==================
$ git diff --unified=0
diff --git a/Mk/bsd.ldap.mk b/Mk/bsd.ldap.mk
index 7e6ec2ffa9f4..f0b513a54d63 100644
--- a/Mk/bsd.ldap.mk
+++ b/Mk/bsd.ldap.mk
@@ -17 +17 @@ Database_Include_MAINTAINER=       ports@FreeBSD.org
-#                 necessary (OpenLDAP 2.4 = 24).
+#                 necessary (OpenLDAP 2.6 = 26).
@@ -20 +20 @@ Database_Include_MAINTAINER=       ports@FreeBSD.org
-#                 Default: 24.
+#                 Default: 26.
@@ -34 +33,0 @@ DEFAULT_OPENLDAP_VER?=   26
-OPENLDAP24_LIB=     libldap-2.4.so.2
diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk
index a6543b0e069f..faa601195447 100644
--- a/Mk/bsd.port.mk
+++ b/Mk/bsd.port.mk
@@ -358 +358 @@ FreeBSD_MAINTAINER=  portmgr@FreeBSD.org
-#                 Implies: WANT_OPENLDAP_VER?=24
+#                 Implies: WANT_OPENLDAP_VER?=26
@@ -360 +360 @@ FreeBSD_MAINTAINER=  portmgr@FreeBSD.org
-#               - Legal values are: 24
+#               - Legal values are: 25 26
==================

$ grep -r --include='*/Makefile*' net/openldap24 .
./mail/cone/Makefile:           libldap_r.so:net/openldap24-client
./net/py-ldap0/Makefile:TEST_DEPENDS=   ${LOCALBASE}/libexec/slapd:net/openldap24-server
./www/glewlwyd/Makefile:                liblber.so:net/openldap24-client \