Bug 267194 - x11/eww: Mark BROKEN on armv7
Summary: x11/eww: Mark BROKEN on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://pkg-status.freebsd.org/ampere...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-19 07:06 UTC by Jesús Daniel Colmenares Oviedo
Modified: 2022-10-20 20:55 UTC (History)
1 user (show)

See Also:


Attachments
eww-0.4.0 (1.17 KB, patch)
2022-10-19 07:06 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff
eww-0.4.0 (1010 bytes, patch)
2022-10-20 01:39 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús Daniel Colmenares Oviedo 2022-10-19 07:06:08 UTC
Created attachment 237451 [details]
eww-0.4.0

Description:

A pkg-fallout log [1] shows that in armv7, kqueue cannot be
compiled because a type does not match (error: E0308).

* Add NOT_FOR_ARCHS=armv7 to avoid compilation on that architecture
  and its reason in NOT_FOR_ARCHS_REASON.

[1] https://pkg-status.freebsd.org/ampere2/data/main-armv7-default/pb46629e97f41_sf341e9bad/logs/eww-wayland-0.4.0.log

QA:

* portlint:
  - WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "FLAVORS".
* testport: OK (poudriere: 13.1-RELEASE, amd64)
Comment 1 Jan Beich freebsd_committer freebsd_triage 2022-10-19 09:09:14 UTC
NOT_FOR_ARCHS is mainly when an architecture will never be supported e.g., big-endian, 32-bit. For regular bustage one should use BROKEN. The error excerpt goes into commit message body (don't just link to a log that may disappear after a year) are fine as it's near impossible to fit enough context into a one-liner to understand the issue if source lines change after an update. For BROKEN/IGNORE or _REASON the value is either an upstream issue or a short human description of the issue.

To fix armv7 applying https://gitlab.com/rust-kqueue/rust-kqueue/-/commit/41ea02d22be7 may help but I can't test due to lack of hardware.
Comment 2 Jesús Daniel Colmenares Oviedo 2022-10-20 01:39:03 UTC
Created attachment 237473 [details]
eww-0.4.0

Hi Jan,

I put BROKEN and change the body commit to display the error excerpt.

> don't just link to a log that may disappear after a year

Sorry, I'll keep in mind.

> I can't test due to lack of hardware.

Thanks for providing me with that link, but I have the same problem: I lack hardware to test it.

---

Thank you very much!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-20 20:55:00 UTC
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-20 20:55:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb0e622ee4e93fd9a90578210e304ec04387789b

commit bb0e622ee4e93fd9a90578210e304ec04387789b
Author:     Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org>
AuthorDate: 2022-10-20 05:56:08 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-20 20:50:55 +0000

    x11/eww: Mark BROKEN on armv7

    PR:             267194
    Reported by:    DtxdF@disroot.org (maintainer)

 x11/eww/Makefile | 2 ++
 1 file changed, 2 insertions(+)