Bug 267196 - deskutils/remind: fix build on FreeBSD 12.
Summary: deskutils/remind: fix build on FreeBSD 12.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://lists.freebsd.org/archives/fr...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-19 12:27 UTC by Robert Clausecker
Modified: 2022-10-20 20:56 UTC (History)
1 user (show)

See Also:


Attachments
deskutils/remind: fix build on FreeBSD 12. (2.53 KB, patch)
2022-10-19 12:27 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-10-19 12:27:43 UTC
Created attachment 237455 [details]
deskutils/remind: fix build on FreeBSD 12.

The header <sys/file.h> doesn't play well with XSI_SOURCE on
FreeBSD <13.  Luckily it isn't actually needed.  Include the
standard header <fcntl.h> instead.

While we are at it, change REINPLACE_CMD use from post-patch
to pre-configure, making it easier to use the makepatch target.

Tested with Poudriere on arm64 FreeBSD 12.3 13.1.
No need to MFH as 2022Q4 is on a version that does not exhibit this issue.

Reported by: fallout (see URL)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-20 20:56:15 UTC
Committed,

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-20 20:56:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6266198345bc09234456296f97db68d7206ee996

commit 6266198345bc09234456296f97db68d7206ee996
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-10-20 05:52:56 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-20 20:52:12 +0000

    deskutils/remind: fix build on FreeBSD 12.

    ChangeLog: https://lists.freebsd.org/archives/freebsd-pkg-fallout/2022-October/282238.html

    PR:             267196
    Reported by:    fuz@fuz.su (maintainer)

 deskutils/remind/Makefile                      |  6 +++---
 deskutils/remind/files/patch-src_Makefile.in   |  4 ++--
 deskutils/remind/files/patch-src_funcs.c (new) | 13 +++++++++++++
 3 files changed, 18 insertions(+), 5 deletions(-)