Bug 267227 - sysutils/loganalyzer: upgrade to php8x breaks log display
Summary: sysutils/loganalyzer: upgrade to php8x breaks log display
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dirk Meyer
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-10-20 14:00 UTC by Simon Wright
Modified: 2022-10-22 03:37 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+

Attachments
Patched functions_common.php to remove the call to magic quotes (723 bytes, application/x-php)
2022-10-20 14:00 UTC, Simon Wright 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Wright 2022-10-20 14:00:29 UTC 
Created attachment 237483 [details]
Patched functions_common.php to remove the call to magic quotes

Issue:
Upgrading from php74 to php8x and then changing from the -php74 flavor to the -php80 flavor breaks loganalyzer display of logs.

Cause:
Magic quotes were deprecated in php74 but still functioned. They have been removed completely in php8x however loganalyzer-php80 still calls them in include/functions_common.php.

This should I guess be fixed upstream but I have had not response from upstream or from the maintainer.

So . . . attached is a bodge to remove the offending call from functions_common.php. It works for me with php80. I am sure that there is a better way of dealing with this but lack experience or time to work further. I hope someone can code patch this correctly or get it fixed upstream.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-10-21 04:50:48 UTC 
^Triage: [tags] in summary lines are mostly deprecated.

(One exception: [new port] is not yet deprecated.)
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2022-10-21 07:44:57 UTC 
Thanks, I will test this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-21 08:01:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e89ef50b4f35c0ab79c75b38359ae926330711dd

commit e89ef50b4f35c0ab79c75b38359ae926330711dd
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2022-10-21 08:01:09 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2022-10-21 08:01:09 +0000

    sysutils/loganalyzer: Update to 4.1.13

    PR: 267227

 sysutils/loganalyzer/Makefile | 2 +-
 sysutils/loganalyzer/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2022-10-21 08:03:00 UTC 
Patch from upstream used to solve this.
Comment 5 Simon Wright 2022-10-21 08:34:17 UTC 
Great, thank you!
Comment 6 Graham Perrin freebsd_committer freebsd_triage 2022-10-22 03:37:53 UTC 
Thanks. 

^Triage: remove the 'patch' keyword (deprecated; bug 267176).