Bug 267369 - x11-themes/cursor-crystal-theme: install broken symlinks
Summary: x11-themes/cursor-crystal-theme: install broken symlinks
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-26 17:59 UTC by Ivan Rozhuk
Modified: 2022-10-30 10:26 UTC (History)
2 users (show)

See Also:

Attachments
Patch to remove broken links (2.52 KB, patch)
2022-10-28 11:33 UTC, Fernando Apesteguía 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2022-10-26 17:59:23 UTC 
cursor-crystal-theme-1.1.1_6: /usr/local/share/icons/crystalblueleft/cursors/plus
cursor-crystal-theme-1.1.1_6: /usr/local/share/icons/crystalgrayleft/cursors/plus
cursor-crystal-theme-1.1.1_6: /usr/local/share/icons/crystalgreenleft/cursors/plus
cursor-crystal-theme-1.1.1_6: /usr/local/share/icons/crystalwhiteleft/cursors/plus

# ls /usr/local/share/icons/crystalgrayleft/cursors/plus
lrwxr-xr-x  1 root  wheel     5B Oct 26 19:54:36 2022 /usr/local/share/icons/crystalgrayleft/cursors/plus@ -> cross
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-28 10:38:15 UTC 
Thanks for reporting this.

AFAICT this seems like a problem in upstream. I don't see anything that could be breaking the port on our side.

It seems it is the left-handed version of the cursors the ones that are broken.

$ for fname in $(find . -name plus);do file "${fname}";done
./crystalgray/cursors/plus: symbolic link to cross
./crystalblueleft/cursors/plus: broken symbolic link to cross
./crystalblue/cursors/plus: symbolic link to cross
./crystalgrayleft/cursors/plus: broken symbolic link to cross
./crystalgreenleft/cursors/plus: broken symbolic link to cross
./crystalgreen/cursors/plus: symbolic link to cross
./crystalwhite/cursors/plus: symbolic link to cross
./crystalwhiteleft/cursors/plus: broken symbolic link to cross

I could make them point to the right-handed version but I don't know if that is acceptable as a workaround.

Would you be able to provide a better alternative?
Comment 2 Ivan Rozhuk 2022-10-28 10:57:35 UTC 
Make it point to something or remove :)

Probably, if they point to nothing and no one report it - this is what users want, so removing broken symlinks is silent fix this bug.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-28 11:33:01 UTC 
Created attachment 237689 [details]
Patch to remove broken links

Would you try this?
Comment 4 Ivan Rozhuk 2022-10-29 19:03:33 UTC 
Yes, it work for me, thanks!
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-30 10:26:17 UTC 
Committed,

Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-30 10:26:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=11a84b2a670e6147b250bbc8819a005427494f84

commit 11a84b2a670e6147b250bbc8819a005427494f84
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-10-28 11:17:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-30 10:22:07 +0000

    x11-themes/cursor-crystal-theme: remove broken symlinks

    Upstream installs some broken symlinks.

    PR:             267369
    Reported by:    rozhuk.im@gmail.com
    Reviewed by:
    Tested by:

 x11-themes/cursor-crystal-theme/Makefile  | 3 ++-
 x11-themes/cursor-crystal-theme/pkg-plist | 4 ----
 2 files changed, 2 insertions(+), 5 deletions(-)